added some tests for apps package #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for three core modules in the apps package: app_events, app_plugins, and app_process. The tests focus on verifying the functionality of EventManager, PluginProcessor, and ActivityProcessor classes.
Key changes:
- Added unit tests for ActivityProcessor middleware chain execution
- Added tests for PluginProcessor plugin initialization and dependency injection
- Added tests for EventManager event handling across different activity types
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/apps/tests/test_app_process.py | Tests ActivityProcessor middleware chain execution with mock handlers |
| packages/apps/tests/test_app_plugins.py | Tests PluginProcessor initialization, duplicate detection, and dependency injection |
| packages/apps/tests/test_app_events.py | Tests EventManager event handling for activities, errors, and responses |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
singhk97
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added some tests for app_events, app_plugins and app_process