Fix issue with lost edits in config UI #13746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-mcmanus
approved these changes
Jul 7, 2025
Subham-KRLX
pushed a commit
to Subham-KRLX/vscode-cpptools
that referenced
this pull request
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13636
Without
retainContextWhenHidden, a webview will be destroyed when obscured (not visible).Alternatively, it may be possible to set aside some data while editing a field so the edit can be applied when the webview is disposed. (We definitely don't want to be applying edits to the configuration while values are still being typed). Not disposing when hidden is much simpler.
My opinion is that this is working around a VS Code bug. We should be able to leverage "change" events, without having to be aware of the disposal behavior. microsoft/vscode#253146 (comment)