[themes] Dark theme in 0.10.5 less colorful than in 0.10.3

[gpbl]

I've upgraded from 0.10.3 to 0.10.5, and the javascript syntax highlighting doesn't work as well as before (OSX El Capitan):

from this:

to this:

I also removed any extension I've installed, but it didn't fix it...

[lcrespom]

I am using Monokai, where function parameters are displayed in orange, but with this update the parameters are displayed in gray although the Monokai.tmTheme clearly states that parameters should be orange (#FD971F).

This may seem like nitpicking, but good syntax highlighting is my top criterion for selecting one or other code editor.

[bgse]

Same issue exists on Linux version.

@bpasero I tend to agree with @lcrespom here, this is a fairly major thing that might even make parts of the user base skip 0.10.5 and as such I'd like to vote for raising the priority on this one.

[bgse]

More on this, look at how missing space in for-loop breaks even more of following highlighting in 0.10.5, below the same in 0.10.3 which is perfect:

Additional observation, breaks for less-than sign, but not for greater-than sign in 0.10.5:

Edit: Looks like the for-loop issue might be this one: microsoft/TypeScript-TmLanguage#17

[adnan333bd]

Facing same issue with typescript.
Access modifier 'private' in the constructor, class names and interface names are not colored as expected ...

[MacKentoch]

So now I feel less alone with syntax highlighting issues.

Got same issues with javascript ES6.
As examples

• import (was red before) is now just grey
• constructor is now grey

Occurs in OSX El capitan and windows 10.

Jsx seems not that much impacted (but still improvements to be done).

To conclude, thank you for all that work already done in VSCode 👍

[irakliy81]

+1 with TypeScript on Windows 10 - some keywords such as typeof and instanceof are not highlighted at all

[egamma]

Apologies for all the inconveniences. There are several different issues in this issue that we need to untangle.

First some background...

• Between 0.9.0 and 0.10.3 we switched to textmate grammars for most languages.
• In 0.10.5 we have switched to another grammar for JS coloring. This was done to support ES6 syntax in JS. We are now using the same grammar that is used for TypeScript for JS and we are working with the TypeScript team to address JS grammar issues.

Unfortunately, these changes have impacted the default Dark and Light theme. As described in the test plan our goal was to get back as close as possible to what we had in 0.9.0. The reasoning was that there are many more other colorful themes provided (e.g. monokai) if users want more color for JS.

Now to the different issues:

@gpbl in 0.9.0 the Dark theme was less colorful and it matched the Dark theme of Visual Studio. We went back to this one. Obviously you got used to the coloring we had in 0.10.3 and we were not sensitive enough here when we made the decision to go back to the colors of 0.9.0. My suggestion is to provide a Dark* theme as an extension that is aligned with what 0.10.3 provided as soon as possible. We can then decide to switch the default Dark theme. Let's keep this issue open to track this problem. I've adjusted the title. Can you try to use another dark theme in the mean time?

@lcrespom this looks like a bug in how we render this token type the Monokai theme. I've extracted this bug into issue #1504

More on this, look at how missing space in for-loop breaks even more of following highlighting in 0.10.5

@bgse This is issue microsoft/TypeScript-TmLanguage#17 as you figured above.

@adnan333bd the reduced colors in the Dark theme also show up in TypeScript.

@MacKentoch this looks like a bug in the TypeScript grammar. Extracted into microsoft/TypeScript-TmLanguage#32. Can you please add a snippet to reproduce the problem.

@irakliy81 this looks like an issue in the TypeScript grammar. Can you please report in Microsoft/TypeScript-TmLanguage with a snippet illustrating the issue.

[adnan333bd]

thanks @egamma , I rather use Solarized Light. Thanks, you guys are doing great!