Skip to content

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 29, 2025

Bumps tracing-subscriber from 0.3.19 to 0.3.20. Also explicitly includes regex in wdk-build to enable case-insensitive regex via unicode-case feature. related to rust-lang/rust-bindgen#3289

Release notes

Sourced from tracing-subscriber's releases.

tracing-subscriber 0.3.20

Security Fix: ANSI Escape Sequence Injection (CVE-TBD)

Impact

Previous versions of tracing-subscriber were vulnerable to ANSI escape sequence injection attacks. Untrusted user input containing ANSI escape sequences could be injected into terminal output when logged, potentially allowing attackers to:

  • Manipulate terminal title bars
  • Clear screens or modify terminal display
  • Potentially mislead users through terminal manipulation

In isolation, impact is minimal, however security issues have been found in terminal emulators that enabled an attacker to use ANSI escape sequences via logs to exploit vulnerabilities in the terminal emulator.

Solution

Version 0.3.20 fixes this vulnerability by escaping ANSI control characters in when writing events to destinations that may be printed to the terminal.

Affected Versions

All versions of tracing-subscriber prior to 0.3.20 are affected by this vulnerability.

Recommendations

Immediate Action Required: We recommend upgrading to tracing-subscriber 0.3.20 immediately, especially if your application:

  • Logs user-provided input (form data, HTTP headers, query parameters, etc.)
  • Runs in environments where terminal output is displayed to users

Migration

This is a patch release with no breaking API changes. Simply update your Cargo.toml:

[dependencies]
tracing-subscriber = "0.3.20"

Acknowledgments

We would like to thank zefr0x who responsibly reported the issue at [email protected].

If you believe you have found a security vulnerability in any tokio-rs project, please email us at [email protected].

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added type:dependabot Pull requests generated by Dependbot that updates a dependency file type:dependencies-cargo Pull requests generated by Dependbot that updates a Cargo Dependencies labels Aug 29, 2025
@wmmc88
Copy link
Collaborator

wmmc88 commented Sep 2, 2025

@dependabot rebase

Bumps [tracing-subscriber](https://github.com/tokio-rs/tracing) from 0.3.19 to 0.3.20.
- [Release notes](https://github.com/tokio-rs/tracing/releases)
- [Commits](tokio-rs/tracing@tracing-subscriber-0.3.19...tracing-subscriber-0.3.20)

---
updated-dependencies:
- dependency-name: tracing-subscriber
  dependency-version: 0.3.20
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/cargo/tracing-subscriber-0.3.20 branch from e86163e to a596874 Compare September 2, 2025 21:09
@gurry gurry force-pushed the dependabot/cargo/tracing-subscriber-0.3.20 branch from 779dd45 to 7dbb48f Compare September 4, 2025 13:22
to fix failures in binding generation.

We use case-inensistive regex patterns while calling allowlist_file() at some
places. This does not work without the unicode-case feature. In the past it
used to be enabled by tracing-subscriber which served our allowlist-file()
use-case as well by accident. But the new version of tracing-subscriber
has removed the dependency on the regex crate thereboy breaking our
bindgen code.

In this fix we have added an explicit depenency on regex ourselves with
said feature enabled.
@gurry gurry force-pushed the dependabot/cargo/tracing-subscriber-0.3.20 branch from 7dbb48f to 4541d6c Compare September 4, 2025 13:28
@wmmc88 wmmc88 requested a review from a team September 8, 2025 18:50
Copy link
Collaborator

@wmmc88 wmmc88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR also seems to introduce 2 different versions of windows-sys into the build. This is not ideal for build times etc, but we can push that fix to a followup to unblock pipelines rn. It should just involving determining what's bringing in the duplicate versions and trying to uses cargo update to target an update to one. It might involve submitting a pr to loosen windows-sys version in a dependency, but i doubt that would be needed in this case since there are no new deps introduced in this pr.

Not sure why clippy isn't catching the duplicate though since we should already have https://rust-lang.github.io/rust-clippy/master/index.html#multiple_crate_versions enabled

@wmmc88
Copy link
Collaborator

wmmc88 commented Sep 8, 2025

This PR also seems to introduce 2 different versions of windows-sys into the build. This is not ideal for build times etc, but we can push that fix to a followup to unblock pipelines rn. It should just involving determining what's bringing in the duplicate versions and trying to uses cargo update to target an update to one. It might involve submitting a pr to loosen windows-sys version in a dependency, but i doubt that would be needed in this case since there are no new deps introduced in this pr.

Not sure why clippy isn't catching the duplicate thought since we should already have https://rust-lang.github.io/rust-clippy/master/index.html#multiple_crate_versions enabled

tracking this in #500

@krishnakumar4a4
Copy link
Contributor

krishnakumar4a4 commented Sep 9, 2025

This PR also seems to introduce 2 different versions of windows-sys into the build. This is not ideal for build times etc, but we can push that fix to a followup to unblock pipelines rn. It should just involving determining what's bringing in the duplicate versions and trying to uses cargo update to target an update to one. It might involve submitting a pr to loosen windows-sys version in a dependency, but i doubt that would be needed in this case since there are no new deps introduced in this pr.

Not sure why clippy isn't catching the duplicate though since we should already have https://rust-lang.github.io/rust-clippy/master/index.html#multiple_crate_versions enabled

Looking at the Cargo.lock file, It seems (the new windows-sys 0.52.0 version) to have come from tracing-subscriber > nu-ansi-term dep which moved from 0.46.0 to 0.50.1 version with this update.

@wmmc88 wmmc88 merged commit 4c756cc into main Sep 9, 2025
504 of 505 checks passed
@wmmc88 wmmc88 deleted the dependabot/cargo/tracing-subscriber-0.3.20 branch September 9, 2025 03:40
@wmmc88
Copy link
Collaborator

wmmc88 commented Sep 9, 2025

This PR also seems to introduce 2 different versions of windows-sys into the build. This is not ideal for build times etc, but we can push that fix to a followup to unblock pipelines rn. It should just involving determining what's bringing in the duplicate versions and trying to uses cargo update to target an update to one. It might involve submitting a pr to loosen windows-sys version in a dependency, but i doubt that would be needed in this case since there are no new deps introduced in this pr.
Not sure why clippy isn't catching the duplicate though since we should already have https://rust-lang.github.io/rust-clippy/master/index.html#multiple_crate_versions enabled

Looking at the Cargo.lock file, It seems (the new windows-sys 0.52.0 version) to have come from tracing-subscriber > nu-ansi-term dep which moved from 0.46.0 to 0.50.1 version with this update.

yup. That's captured in #500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:dependabot Pull requests generated by Dependbot that updates a dependency file type:dependencies-cargo Pull requests generated by Dependbot that updates a Cargo Dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2025-0055: Logging user input may result in poisoning logs with ANSI escape sequences
3 participants