-
-
Notifications
You must be signed in to change notification settings - Fork 315
Update analyzer to >=7.4.0 <9.0.0 and bump related packages #1055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As requested in the PR template, pinging some folks for review: Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the mobx_codegen
package to use analyzer version 8.1.1 and resolves all associated deprecations by migrating from the deprecated Element v2 API to the current Element API.
- Upgraded
analyzer
to ^8.1.1 along with related packages (build
,source_gen
,build_runner
,build_resolvers
) - Replaced all deprecated Element2 API usage with the current Element API throughout the codebase
- Updated type checker instantiation from runtime-based to package-scoped references
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
mobx_examples/lib/clock/clock.dart | Changed parameter type from implicit to explicit dynamic |
mobx_codegen/pubspec.yaml | Updated package versions and incremented version to 2.7.3 |
mobx_codegen/lib/version.dart | Updated version constant to match pubspec |
mobx_codegen/CHANGELOG.md | Added changelog entry for version 2.7.3 |
mobx_codegen/test/util_test.dart | Updated import and removed deprecated API usage in test mocks |
mobx_codegen/test/store_class_visitor_test.dart | Updated test mocks to use current Element API |
mobx_codegen/lib/src/type_names.dart | Migrated from Element2 to Element API throughout type name resolution |
mobx_codegen/lib/src/template/*.dart | Updated template classes to use current Element API |
mobx_codegen/lib/src/store_class_visitor.dart | Comprehensive migration from Element2 API and updated TypeChecker usage |
mobx_codegen/lib/src/mobx_codegen_base.dart | Updated core generator logic to use current Element API |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
I've updated this PR to widen the supported analyzer range, and I've confirmed this support by setting a few overrides including |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 12 out of 12 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
@all-contributors |
I've put up a pull request to add @josh-audio! 🎉 |
This PR updates
mobx_codegen
to useanalyzer: '>=7.4.0 < 9.0.0'
, and also upgrades some related packages.analyzer >= 8.0.0
removes the oldElement
v1 API, and deprecates the v2 names (e.g.ClassElement2
).This PR also resolves associated deprecations, and removes all deprecation ignore comments except for one, which is unrelated to this change as far as I can tell.Deprecation changes have been reverted, see discussion below.
Pull Request Checklist
pubspec.yaml
is updated.major
/minor
/patch
/patch-count
, depending on the complexity of changemelos run set_version
command from the root directory