Added go binary help validate the releases website #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t the providers folder. Signed-off-by: Gary Bright <[email protected]>
There was a problem hiding this comment.
This is awesome work!
Committing a binary to the repo struck me as unusual though, and got me thinking:
- we already have (https://github.com/mondoohq/installer/blob/main/test/releases/validate_release.py) in python in this repo, would it make sense to keep them in python for the sake of simplicity and readability (i realize this is a greater discussion)
- how can we avoid commiting binaries into the repo? Since the code is already Go, wouldn't the best place to keep the sources be the releasr repo itself, perhaps as a
releasr validatecommand - then we can leverage all the logic already inside that binary and make more powerful tests?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a gap in our testing at the moment with regards to the
releases.mondoo.comwebsite. Sometimes the reindex task truncates all the folders and only lists the providers folder. As seen in this exampleThe existing tests validate the json which is there and correct but not the html so the user can't browse and download the required package
Example of the task within the existing action
https://github.com/mondoohq/installer/actions/runs/16348449746/job/46188454945