Skip to content

Conversation

claytoncasey01
Copy link
Contributor

@claytoncasey01 claytoncasey01 commented Aug 15, 2025

This PR updates the SentinelOne documentation to specify that the host protocol is required. It also adds some basic validation to make sure this is actually the case.

Fixes: #283

Copy link
Contributor

@vjeffrey vjeffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

part of me wants to say let's just do it for the user if they don't include it themselves, but this solves the issue, so 👍
if someone complains we can adjust to do it for them if they forget to include the https://

@vjeffrey
Copy link
Contributor

vjeffrey commented Aug 15, 2025

@claytoncasey01 claytoncasey01 merged commit 700c416 into main Aug 15, 2025
13 checks passed
@claytoncasey01 claytoncasey01 deleted the claytoncasey01/sent-one-updates branch August 15, 2025 20:10
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SentinalOne: Incorrect host protocol
2 participants