Ensure locks are released when leaving a Countdown context #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a Countdown as a context manager with a lock, there was a possibility of not releasing the lock when exiting the context (if unlucky with timeouts). As an example, when processing a large batch of basic_publish calls using a short timeout, there is a certain probability that the timeout will be hit during the put operation, for instance. This means that when the time comes to run __aexit__, the Countdown logic will short-circuit, causing the lock.release() to never be called.
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a Countdown as a context manager with a lock, there was a possibility of not releasing the lock when exiting the context (if unlucky with timeouts).
As an example, when processing a large batch of basic_publish calls using a short timeout, there is a certain probability that the timeout will be hit during the put operation, for instance. This means that when the time comes to run aexit, the Countdown logic will short-circuit, causing the lock.release() to never be called.