Containers: add explicit StridedDimension conversion from/to external types #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to the implicit conversion. Desired use case is for types where we still want to have a conversion for convenience purposes, but the conversion is potentially dangerous (such as Magnum's Vector3i -> Size3D).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #162 +/- ##
=======================================
Coverage 97.97% 97.97%
=======================================
Files 136 136
Lines 11086 11089 +3
=======================================
+ Hits 10861 10864 +3
Misses 225 225 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the implicit conversion. Desired use case is for types where we still want to have a conversion for convenience purposes, but the conversion is potentially dangerous (such as Magnum's
Vector3i->Size3D).Fails to compile on MSVC 2019 and earlier due to the compiler thinking the two constructors / conversion operators are the same. 2022 works; all other compilers including GCC 4.8 work as well. The seemingly-conflicting overload is based on the answers in https://stackoverflow.com/questions/14600201/why-should-i-avoid-stdenable-if-in-function-signatures, there isn't any indication of MSVC being the odd one out.