fixes #699 - implement functions from pgsql #860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jexp
requested changes
Jul 14, 2018
src/main/java/apoc/coll/Coll.java
Outdated
| @UserFunction | ||
| @Description("apoc.coll.different(values) - returns true if values are different") | ||
| public boolean different(@Name("values") List<Object> values) { | ||
| for(int i=0; i<values.size()-1;i++){ |
There was a problem hiding this comment.
always use foreach
this one is just return new HashSet(values).size() == values.size()
src/main/java/apoc/label/Label.java
Outdated
| @Description("apoc.label.exists(element, label) - returns true or false related to label existance") | ||
| public boolean exists(@Name("node") Object element, @Name("label") String label) { | ||
|
|
||
| return element instanceof Node?((Node) element).hasLabel(() -> label) : |
There was a problem hiding this comment.
while the lambda approach is cool, I'm not sure if it's more efficient htan just using Label.label(label)
| return degree; | ||
| } | ||
|
|
||
| @UserFunction("apoc.node.degree.in") |
There was a problem hiding this comment.
just use node.getDegree(type, direction)
please no manual counting.
src/main/java/apoc/nodes/Nodes.java
Outdated
| } | ||
|
|
||
| } | ||
| private long getTotalNeighbors(Node node, String types, Direction direction) { |
|
Thanks a lot! |
jexp
pushed a commit
that referenced
this pull request
Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.