Skip to content

FEATURE: Find nodes by their id in Neos Backend #3789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: 9.0
Choose a base branch
from
Open

FEATURE: Find nodes by their id in Neos Backend #3789

wants to merge 7 commits into from

Conversation

bwaidelich
Copy link
Member

@bwaidelich bwaidelich commented May 25, 2024 •
edited
Loading

Extends the custom SearchOperation such that it respects node aggregate ids

Related: #3771

@bwaidelich
FEATURE: Find nodes by their id in Neos Backend
ac24f7c 
Extends the custom `SearchOperation` such that it respects node aggregate ids

Depends on neos/neos-development-collection#5098

Related: #3771
@github-actions github-actions bot added Feature Label to mark the change as feature 9.0 labels May 25, 2024
@bwaidelich bwaidelich mentioned this pull request May 25, 2024
Closed
@bwaidelich
Copy link
Member Author

I have no clue why the e2e tests fail..

grebaldi
grebaldi reviewed Jun 28, 2024
View reviewed changes
@bwaidelich bwaidelich self-assigned this Sep 18, 2024
@bwaidelich bwaidelich closed this Nov 13, 2024
@bwaidelich bwaidelich reopened this Nov 13, 2024
@mhsdesign
Copy link
Member

im still confused what the reason for the search operation is in general but it seems to be used via javascript:

neos-ui/packages/neos-ui-sagas/src/UI/PageTree/index.js

Line 163 in 9e47fdf

matchingNodes = yield query.search(searchQuery, effectiveFilterNodeType).getForTreeWithParents(effectiveFilterNodeType);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grebaldi grebaldi grebaldi left review comments

@dlubitz dlubitz dlubitz approved these changes

Assignees

@bwaidelich bwaidelich

Labels
9.0 Feature Label to mark the change as feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bwaidelich @mhsdesign @grebaldi @dlubitz