fix: eagerly split requests in split_series_attributes #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrys
reviewed
Aug 28, 2025
gabrys
reviewed
Aug 28, 2025
| if not items: | ||
| return | ||
|
|
||
| query_size_limit = env.NEPTUNE_QUERY_MAX_REQUEST_SIZE.get() | ||
| batch_size_limit_env = env.NEPTUNE_QUERY_SERIES_BATCH_SIZE.get() | ||
| max_workers = env.NEPTUNE_QUERY_MAX_WORKERS.get() |
There was a problem hiding this comment.
Suggested change
| max_workers = env.NEPTUNE_QUERY_MAX_WORKERS.get() | |
| max_workers = max(env.NEPTUNE_QUERY_MAX_WORKERS.get(), 10) |
There was a problem hiding this comment.
Should we clip this value? If someone limits the concurrency to 2 workers then it should be fine to split the request into up to 2 groups, because there won't necessarily be any benefit to going above this number?
gabrys
approved these changes
Aug 28, 2025
|
Please test this against simply changing the default to |
michalsosn
force-pushed
the
ms/heuristic-split
branch
from
fd11853 to
3323a3d
Compare
michalsosn
force-pushed
the
ms/heuristic-split
branch
from
8dab410 to
382edbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.