SpotBugs: Fix Method ignores exceptional return value

[alexknop]

There are 16 SpotBugs under

Bad practice:
RV: Bad use of return value from method (16: 0/16/0/0)
Method ignores exceptional return value (16: 0/16/0/0)

Solution:
Leveraging the more modern java.nio.Files library and conducting these make directory, delete, etc. functions via that.
Changing a Submit to an Execute function

[github-actions]

test-Unit test failed, but no output was generated. Maybe a preliminary stage failed.

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15415.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[alperozturk96]

Hello

Thank you very much for your contribution!
We really appreciate the time and effort you’ve put into improving the project. 🙏

When multiple files and different logics are changed together, it becomes difficult for us to test and review effectively, since each area can have its own impact (e.g: #15214 (comment)).

To make review and testing smoother, it would be best if the changes are split into smaller PRs, ideally one PR per logical change in each file.

For example:

A PR focused solely on the move functionality in the private void move(File sourceFile, File targetFile) method of UploadFileOperations.java.

A separate PR for changes to UploadFileOperations.java related to LOCAL_BEHAVIOUR_DELETE within the handleLocalBehaviour method.

A separate PR for modifications to Executors.newCachedThreadPool() in OCFileListFragment.java.

This way, we can test and approve each functionality independently, ensuring quality while avoiding unexpected side effects.

Thanks again for your work 🙌

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[alperozturk96]

Please separate changes. Thank you.

[alexknop]

@alperozturk96 Good idea, closing this to focus on each one individually.