-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: add recommended item view holder #15495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AndyScherzinger
merged 9 commits into
master
from
feat/separate-view-holder-for-recommended-files
Sep 2, 2025
Merged
feat: add recommended item view holder #15495
AndyScherzinger
merged 9 commits into
master
from
feat/separate-view-holder-for-recommended-files
Sep 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alperozturk <[email protected]>
caa0b5a
to
3b4eee4
Compare
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
…ulti select actions Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
kra-mo
approved these changes
Sep 2, 2025
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Fixes f21edf0 ![]() |
Signed-off-by: alperozturk <[email protected]>
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15495.apk |
AndyScherzinger
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
ux-enhancement
Improvements that refine user interactions, accessibility, or overall usability
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Note
Since we’ve added a new text view element for the "reason," the "more" button now needs to align properly between the filename + extension and the reason. To ensure this alignment, I’ve increased the width allocation, which is why you’re now seeing three items instead of four.
If you have any suggestions for a better approach, I’d be happy to hear them. Thanks!