Skip to content

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Sep 1, 2025

  • Tests written, or not not needed
Before After
before after

Changes

  • Uses a new separate view holder for recommended files
  • Filters out correct actions for recommended files since user cannot delete, move, set as favorite, encrypt etc... recommend file.
  • Fixes multi select
  • Adds reason text view element

Note

Since we’ve added a new text view element for the "reason," the "more" button now needs to align properly between the filename + extension and the reason. To ensure this alignment, I’ve increased the width allocation, which is why you’re now seeing three items instead of four.

If you have any suggestions for a better approach, I’d be happy to hear them. Thanks!

@alperozturk96 alperozturk96 linked an issue Sep 1, 2025 that may be closed by this pull request
@alperozturk96 alperozturk96 force-pushed the feat/separate-view-holder-for-recommended-files branch from caa0b5a to 3b4eee4 Compare September 2, 2025 12:12
@alperozturk96 alperozturk96 linked an issue Sep 2, 2025 that may be closed by this pull request
@alperozturk96 alperozturk96 added 3. to review ux-enhancement Improvements that refine user interactions, accessibility, or overall usability labels Sep 2, 2025
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
Copy link
Collaborator Author

Fixes f21edf0

Screenshot 2025-09-02 at 16 41 50

@nextcloud nextcloud deleted a comment from github-actions bot Sep 2, 2025
Signed-off-by: alperozturk <[email protected]>
Copy link

github-actions bot commented Sep 2, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15495.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

Copy link

github-actions bot commented Sep 2, 2025

Codacy

Lint

TypemasterPR
Warnings4848
Errors1111

SpotBugs

CategoryBaseNew
Bad practice5959
Correctness6868
Dodgy code286286
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3535
Performance4848
Security1818
Total524524

@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.34.0 milestone Sep 2, 2025
@AndyScherzinger AndyScherzinger merged commit b7c495b into master Sep 2, 2025
19 of 20 checks passed
@AndyScherzinger AndyScherzinger deleted the feat/separate-view-holder-for-recommended-files branch September 2, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review ux-enhancement Improvements that refine user interactions, accessibility, or overall usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recommended Files Action Needs to be Filtered Create a separate ViewHolder for recommended files
3 participants