Skip to content
This repository was archived by the owner on Oct 24, 2019. It is now read-only.

Conversation

jung-han
Copy link
Member

@jung-han jung-han commented Oct 2, 2019

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

  • use options directly
<grid
  :data="gridProps.data"
  :columns="gridProps.columns"
  :options="gridProps.options"
  :theme="gridProps.myTheme"
  @check="onCheck"
  @uncheck="onUnCheck"
  :rowHeaders="gridProps.rowHeaders"
  :columnOptions="gridProps.columnOptions"
></grid>

Deprecated

  • setLanguage
  • applyTheme

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

src/Grid.vue Outdated
@@ -53,11 +55,12 @@ export default {
}
},
mounted() {
const options = Object.assign({}, this.options, {
const options = Object.assign(this.options, this.$attrs, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

상단의 options props에서 default 값을 반환하는 부분은 없애고, 이 부분을 아래처럼 바꾸는게 좋을 것 같아요.(default 값을 반환해줄 경우 options props가 observer 데이터로 변경이 되네요. 현재 사이드 이펙트는 없는 것 같은데, 일반 객체로 넘기는게 좋을 것 같아요.)

Object.assign(this.options || {}, this.$attrs, {
// ...

Copy link
Contributor

@js87zz js87zz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료입니다. 고생하셨어요~!

@jung-han jung-han merged commit 89dbe1f into master Oct 10, 2019
@jung-han jung-han deleted the chore/apply-props-to-options branch October 10, 2019 04:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants