-
Notifications
You must be signed in to change notification settings - Fork 307
enh: add boldref / sbref to source metadata #3532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3532 +/- ##
==========================================
- Coverage 73.72% 0.42% -73.31%
==========================================
Files 60 59 -1
Lines 4757 4733 -24
Branches 615 614 -1
==========================================
- Hits 3507 20 -3487
- Misses 1109 4713 +3604
+ Partials 141 0 -141 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
Looking at the boldref sources for one of the CI runs.. the idea behind this change was to make it easier to trace whether an sbref or the hmc boldref (which is a derivative of the bold series itself) was used to create it. I don't think we should include working directory files in the sources, so we could consider a few options:
|
Just to pull the contents:
{
"Sources": [
"/scratch/fmriprep_25_2_wf/sub_02_wf/bold_task_cuedSGT_run_01_echo_1_wf/bold_fit_wf/hmc_boldref_wf/gen_avg/sub-02_task-cuedSGT_run-01_echo-1_bold_valid_average.nii.gz",
"bids::sub-02/func/sub-02_task-cuedSGT_run-01_from-boldref_to-auto00000_mode-image_desc-fmap_xfm.txt",
"/scratch/fmriprep_25_2_wf/sub_02_wf/fmap_preproc_wf/wf_auto_00000/bs_filter/fmap_syn0Warp_Hz_trans_coeff000.nii.gz"
]
} |
I think this just shows that we're not using the outputs of a datasink in our buffers. I'll fix that. |
Closes #3498