Skip to content

Don't add the default user to docker group by default #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2022
Merged

Don't add the default user to docker group by default #105

merged 2 commits into from
Jun 15, 2022

Conversation

SuperSandro2000
Copy link
Member

Closes #101

@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review June 10, 2022 09:54
@nzbr
Copy link
Member

nzbr commented Jun 13, 2022

The default for addToDockerGroup should probably be config.security.sudo.wheelNeedsPassword, because by default the user does not have a password anyway

SuperSandro2000
SuperSandro2000 commented Jun 14, 2022
View reviewed changes
@nzbr nzbr added the enhancement New feature or request label Jun 15, 2022
@nzbr nzbr merged commit d820aad into nix-community:main Jun 15, 2022
@SuperSandro2000 SuperSandro2000 deleted the docker branch June 15, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker-native should not always add the default user to the docker group
2 participants
@SuperSandro2000 @nzbr