Skip to content

fix: make wrapper not crash if logger setup fails #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2024
Merged

fix: make wrapper not crash if logger setup fails #496

merged 1 commit into from
Jul 5, 2024

Conversation

nzbr
Copy link
Member

@nzbr nzbr commented Jun 15, 2024

See also #486

@nzbr nzbr added the bug Something isn't working label Jun 15, 2024
@nzbr nzbr requested a review from K900 June 30, 2024 17:05
K900
K900 approved these changes Jun 30, 2024
View reviewed changes
Copy link
Contributor

@K900 K900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is OK, but I'm not sure how helpful it'll be if systemd has failed to start, because we'll probably be shelling into a completely broken system...

@nzbr nzbr merged commit ae1ed75 into main Jul 5, 2024
@nzbr nzbr deleted the shell-wrapper-fix branch July 5, 2024 13:44
@leonbreedt leonbreedt mentioned this pull request Sep 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K900 K900 K900 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nzbr @K900