refactor file dropping to use a single Vec instead of two #571
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change that I noticed could be done in file dropping. There's two Vecs related to dropped files, one for storing the paths and the other for storing the bytes of the files. I thought that having this done as a single Vec of a new DroppedFile struct containing both the path to the file and the bytes of the file is probably a more obvious way of doing this, instead of having two separate Vecs that are ultimately still connected. It also allows for easier further changes, as now you can work with the entire file structs instead of needing to worry about whether or not the Vecs actually match in content counts (which they should always do)