feat: Add keymap descriptions #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @rafamadriz for putting this together. Just one thing, isn't it better to start the description with |
|
@numToStr I thought about that, but I felt that it was better to have a naming convention where you first start with |
numToStr
requested changes
Aug 4, 2022
|
@rafamadriz I agree with you. Please review the requested changes then we could go ahead with merging this :) |
Co-authored-by: Vikas Raj <[email protected]>
Co-authored-by: Vikas Raj <[email protected]>
numToStr
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if you're happy with the descriptions I added, here's a screenshot of the final result: