Avoid possibly blocking calls to mysql_free_result. #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The blocking calls could only occur if the result set from a previous Stmt.execute has not been fetched. Fixes ocaml-community#67.
paurkedal
added a commit
to paurkedal/opam-repository
that referenced
this pull request
May 8, 2025
CHANGES:
- The `mariadb_config` and `mysql_config` scripts are now used, if
available, to discover MariaDB client library (ocaml-community/ocaml-mariadb#65 by Albert Peschar).
- Added server-side properties `get_server_info`, `get_server_version`,
`get_host_info` and `get_proto_info` (ocaml-community/ocaml-mariadb#62 by Petter A. Urkedal).
- Avoid calling `mysql_stmt_free_result` if there is no result set, since
this is not allowed by recent versions of the client library (by Petter
A. Urkedal, fixes ocaml-community/ocaml-mariadb#64).
- Avoid possibly blocking calls to `mysql_free_result` in the nonblocking
implementation. This was only an issue if a previous result set had not
been consumed (ocaml-community/ocaml-mariadb#68 by Petter A. Urkedal, fixes ocaml-community/ocaml-mariadb#67).
- Fix memory leak in non-blocking test suite (Petter A. Urkedal, fixes
ocaml-community/ocaml-mariadb#29).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The blocking calls could only occur if the result set from a previous Stmt.execute has not been fetched.
Fixes #67.