Extended opentelemetry (alternative) #7500
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create Entity/EntityBuilder class in internal package - Update serialization code Need to discuss how to work with Resource going forward.
- Remove ResourceWithEntity, no way to keep bincompat that way - Update toString tests to be a lot more forgiving, but preserve intent
- fix reflective method lookup - also add unit test in the right project.
- Creates an API matching EntityProvider OTEP - Updates EntityDetector to be ResourceDetector - Creates synchronous "update resource with this entity" method. - Adds wiring for incubating API + incubating SDK Note: Still have some thoughts and ideas about a formal API, this may still change.
- Remove `Entity` and only expose `EntityBuilder` similar to how we do `LogRecord`s. - Have methods on `Resource` which determine if you're attaching the entity, simplify "remove" or just ignore for now.
…OpenTelemetry API. - Update shared state in SDK to use Supplier<Resource> instead of Resource - Add helper utils to expose private methods to supply the supplier - Create new ExtendedOpenTelemetry* API/SDK and end-to-end test.
…internal/otlp/EntityRefMarshaler.java Co-authored-by: jack-berg <[email protected]>
…iderBuilder.java Co-authored-by: jack-berg <[email protected]>
- Hide more methods (no incubating methods in public APIs that are not internal) - Update builder API to use attributes directly - Use static instances in Noop API
Merged
zeitlinger
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7500 +/- ##
============================================
- Coverage 89.99% 89.97% -0.03%
- Complexity 7078 7104 +26
============================================
Files 803 808 +5
Lines 21405 21507 +102
Branches 2086 2087 +1
============================================
+ Hits 19263 19350 +87
- Misses 1479 1493 +14
- Partials 663 664 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@trask @jaydeluca @jack-berg I was able to come up with a variant of ExtendedOpenTelemetry that does not result in any API changes |
|
closing in favor of #7496 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7495
Alternative implementation that does not remove final from
OpenTelemetrySdk