instrumentation-fastify fails to initialise if "type" is set to "module" in package.json

[mgcrea]

What version of OpenTelemetry are you using?

Latest versions available:

    "@opentelemetry/api": "^1.4.1",
    "@opentelemetry/auto-instrumentations-node": "^0.37.0",
    "@opentelemetry/exporter-metrics-otlp-proto": "^0.39.1",
    "@opentelemetry/exporter-prometheus": "^0.39.1",
    "@opentelemetry/exporter-trace-otlp-proto": "^0.39.1",
    "@opentelemetry/instrumentation": "^0.39.1",
    "@opentelemetry/instrumentation-fastify": "^0.31.3",
    "@opentelemetry/instrumentation-http": "^0.39.1",
    "@opentelemetry/resources": "^1.13.0",
    "@opentelemetry/sdk-metrics": "^1.13.0",
    "@opentelemetry/sdk-node": "^0.39.1",
    "@opentelemetry/sdk-trace-base": "^1.13.0",
    "@opentelemetry/sdk-trace-node": "^1.13.0",
    "@opentelemetry/semantic-conventions": "^1.13.0",

What version of Node are you using?

v18.16.0

What did you do?

Tried to use @opentelemetry/instrumentation-fastify on a new project did not understand why the instrumentation did not work.

What did you expect to see?

@opentelemetry/instrumentation-fastify Applying patch for fastify@4.17.0

What did you see instead?

nothing

Additional context

instrumentation-http works in both modes:

@opentelemetry/instrumentation-http Applying patch for http@18.16.0
@opentelemetry/instrumentation-http Applying patch for https@18.16.0

[Flarna]

support for instrumenting ESM was recently merged (see open-telemetry/opentelemetry-js#3698) but it's not yet in a release.

Please retest once a new release is out.

[dyladan]

New release is out. Can you please confirm if this is fixed?

[pichlermarc]

Closing this as it should work as of the latest release.
Feel free to comment if we should re-open the issue. 🙂

[nlindley]

This appears to still be a problem. We converted the Fastify example to ESM and see the HTTP modules being patched, but not fastify. nlindley/opentelemetry-js-contrib@main...fastify-esm