Enable semantic voice activity detection option #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsquire
reviewed
Jul 21, 2025
| [CodeGenType("RealtimeResponseUsage")] public partial class ConversationTokenUsage { } | ||
| [CodeGenType("RealtimeToolType")] public readonly partial struct ConversationToolKind { } | ||
| [CodeGenType("DotNetRealtimeVoiceIds")] public readonly partial struct ConversationVoice { } | ||
| [CodeGenType("RealtimeSemanticVadTurnDetectionEagerness")] public readonly partial struct SemanticEagernessLevel { } |
There was a problem hiding this comment.
I wonder if we can use a visitor to generate these rather than having to maintain stubs here.
There was a problem hiding this comment.
I totally agree with this. We’ve been maintaining separate generator stubs per client, and switching to a visitor would make it much easier to manage these going forward. I’ve created an issue to track this: #550, and we’ll look into addressing it as part of that. Thanks for the suggestion!
| namespace OpenAI.Realtime | ||
| { | ||
| [Experimental("OPENAI002")] | ||
| public readonly partial struct SemanticEagernessLevel : IEquatable<SemanticEagernessLevel> |
jsquire
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #543
The method
TurnDetectionOptions.CreateSemanticVoiceActivityTurnDetectionOptionswas originally marked asinternalto simplify the previous release and allow for iterative development.This PR updates the method to
public, making it accessible to users who want to configure conversation sessions using semantic VAD (Voice Activity Detection).