[1.3] ci fixes + support for scheduled ci jobs #4763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 8742074 neglects to update the exclusion rules when bumping Go releases, and so we no longer exclude running on actuated with older Go release, or running with criu-dev with older Go release. Fixes: 8742074 ("CI: add Go 1.24, drop go1.22") Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit 0628b1e) Signed-off-by: Kir Kolyshkin <[email protected]>
... or from another job. Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit 9d970f1) Signed-off-by: Kir Kolyshkin <[email protected]>
When we run CI not on a pull request, the commit job is skipped, as a result, all-done is also skipped. To allow all-done to succeed, modify the commit job to succeed for non-PRs. Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit 43955a0) Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
changed the title
|
@opencontainers/runc-maintainers PTAL |
|
Why most of CI jobs didn't run in this PR? |
lifubang
approved these changes
May 10, 2025
I guess it's because I originally forgot to change the branch to release-1.3, and later, when I did, github did not restart some jobs. The only way to work around that is close/reopen the PR, which @AkihiroSuda did (thank you). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial backport of #4760 to release-1.3 branch, fixing some issues and allowing the scheduled jobs to be run on release-1.3 branch.