Skip to content

Conversation

kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Jul 14, 2025

The dmem controller is added into kernel v6.13 and is now enabled in
Fedora 42 kernels. Yet, systemd is not aware of dmem.

This fixes the test case failure on Fedora.

For the initial test case, see commit 2751571.

For earlier commits similar to this one, see
commits 601cf58, 0527271, e83ca51.

@kolyshkin kolyshkin added area/ci backport/1.2-todo A PR in main branch which needs to be backported to release-1.2 backport/1.3-todo A PR in main branch which needs to be backported to release-1.3 labels Jul 14, 2025
@kolyshkin kolyshkin requested review from lifubang and rata and removed request for lifubang July 14, 2025 22:14
@kolyshkin
Copy link
Contributor Author

The alternative to this is to list all controllers known to systemd (rather than the ones that are unknown).

@thaJeztah
Copy link
Member

Some failure on Ubuntu;

ok 305 update memory vs CheckBeforeUpdate
not ok 306 update per-device iops/bps values
# (in test file tests/integration/update.bats, line 917)
#   `[ "$status" -eq 0 ]' failed
# runc spec (status=0):
#
# runc run -d --console-socket /tmp/bats-run-HYS9G4/runc.3xTkz8/tty/sock test_update (status=1):
# time="2025-07-14T22:19:14Z" level=error msg="runc run failed: unable to start container process: error during container init: error setting cgroup config for procHooks process: failed to write \"259:0 rbps=485760\": write /sys/fs/cgroup/runc-cgroups-integration-test/test-cgroup-27654/io.max: no such device"
# --- teardown ---

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin
Copy link
Contributor Author

Some failure on Ubuntu;

ok 305 update memory vs CheckBeforeUpdate
not ok 306 update per-device iops/bps values
# (in test file tests/integration/update.bats, line 917)
#   `[ "$status" -eq 0 ]' failed
# runc spec (status=0):
#
# runc run -d --console-socket /tmp/bats-run-HYS9G4/runc.3xTkz8/tty/sock test_update (status=1):
# time="2025-07-14T22:19:14Z" level=error msg="runc run failed: unable to start container process: error during container init: error setting cgroup config for procHooks process: failed to write \"259:0 rbps=485760\": write /sys/fs/cgroup/runc-cgroups-integration-test/test-cgroup-27654/io.max: no such device"
# --- teardown ---

This appears to be a new flake :( but is def unrelated to the fix.

The dmem controller is added into kernel v6.13 and is now enabled in
Fedora 42 kernels. Yet, systemd is not aware of dmem.

This fixes the test case failure on Fedora.

For the initial test case, see commit 2751571.

For earlier commits similar to this one, see
commits 601cf58, 0527271, e83ca51.

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin
Copy link
Contributor Author

Some failure on Ubuntu;

ok 305 update memory vs CheckBeforeUpdate
not ok 306 update per-device iops/bps values
# (in test file tests/integration/update.bats, line 917)
#   `[ "$status" -eq 0 ]' failed
# runc spec (status=0):
#
# runc run -d --console-socket /tmp/bats-run-HYS9G4/runc.3xTkz8/tty/sock test_update (status=1):
# time="2025-07-14T22:19:14Z" level=error msg="runc run failed: unable to start container process: error during container init: error setting cgroup config for procHooks process: failed to write \"259:0 rbps=485760\": write /sys/fs/cgroup/runc-cgroups-integration-test/test-cgroup-27654/io.max: no such device"
# --- teardown ---

This appears to be a new flake :( but is def unrelated to the fix.

Being fixed in #4807, PTAL

@lifubang lifubang merged commit 2a6e143 into opencontainers:main Jul 15, 2025
29 of 31 checks passed
@kolyshkin kolyshkin added backport/1.2-done A PR in main branch which has been backported to release-1.2 backport/1.3-done A PR in main branch which has been backported to release-1.3 and removed backport/1.2-todo A PR in main branch which needs to be backported to release-1.2 backport/1.3-todo A PR in main branch which needs to be backported to release-1.3 labels Jul 15, 2025
@kolyshkin
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci backport/1.2-done A PR in main branch which has been backported to release-1.2 backport/1.3-done A PR in main branch which has been backported to release-1.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants