Skip to content

Conversation

djelinski
Copy link
Member

@djelinski djelinski commented Sep 15, 2025

The DTLSReassembler may release a Finished message before assembling all necessary fragments.

The newly added test fails without the DTLSReassembler changes, passes with the changes. Other tier1-3 tests continue to pass.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8367133: DTLS: fragmentation of Finished message results in handshake failure (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27284/head:pull/27284
$ git checkout pull/27284

Update a local copy of the PR:
$ git checkout pull/27284
$ git pull https://git.openjdk.org/jdk.git pull/27284/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27284

View PR using the GUI difftool:
$ git pr show -t 27284

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27284.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2025

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 15, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8367133 8367133: DTLS: fragmentation of Finished message results in handshake failure Sep 15, 2025
@openjdk
Copy link

openjdk bot commented Sep 15, 2025

@djelinski The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@djelinski djelinski marked this pull request as ready for review September 15, 2025 10:57
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 15, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 15, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review security [email protected]
Development

Successfully merging this pull request may close these issues.

1 participant