8367112: HttpClient does not support Named Groups set on SSLParameters

[djelinski]

HttpClient currently ignores the named groups and signature schemes configured on the SSLParameters. Given that it processes the configured protocols and cipher suites, I think it should process named groups and signature schemes as well.

Tier1-3 tests continue to pass.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8367112: HttpClient does not support Named Groups set on SSLParameters (Bug - P4)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)
• Daniel Fuchs (@dfuch - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27292/head:pull/27292
$ git checkout pull/27292

Update a local copy of the PR:
$ git checkout pull/27292
$ git pull https://git.openjdk.org/jdk.git pull/27292/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27292

View PR using the GUI difftool:
$ git pr show -t 27292

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27292.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8367112: HttpClient does not support Named Groups set on SSLParameters

Reviewed-by: jpai, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• c82070e: 8366775: TestCompileTaskTimeout should use timeoutFactor
• 0bc3705: 8367597: Runtime.exit logging failed: Cannot invoke "java.lang.Module.getClassLoader()" because "m" is null
• c7f014e: 8356813: Improve Mod(I|L)Node::Value
• ... and 17 more: https://git.openjdk.org/jdk/compare/1cb1267ce84dea2bfcb434b03c982b859997c6d2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@djelinski The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (11d26899)

[jaikiran]

This looks OK to me.

[dfuch]

This looks reasonable.

[djelinski]

Thanks for the reviews!

/integrate

[openjdk]

Going to push as commit d7eeacf.
Since your change was applied there have been 42 commits pushed to the master branch:

• 91afdaf: 8367860: Remove unused NMethodToOopClosure::fix_relocations
• 1ba8414: 8367573: JNI exception pending in os_getCmdlineAndUserInfo of ProcessHandleImpl_aix.c
• b00e0da: 8367728: IGV: dump node address type
• ... and 39 more: https://git.openjdk.org/jdk/compare/1cb1267ce84dea2bfcb434b03c982b859997c6d2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@djelinski Pushed as commit d7eeacf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[seanjmullan]

This seems like a change that would be useful to document in a release note.

[dfuch]

Ah! Good point. Thanks for chiming in @seanjmullan ... I have added the release-note=yes label to the JBS issue so that we don't forget. @djelinski could you work on the release note while your memory of the issue is fresh?