SRT2RTMP: fix srt bridge hevc to rtmp error. v7.0.84 #4446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzp1984
force-pushed
the
bugfix/srt-bridge-hevc-to-rtmp
branch
from
7eb3f7c to
6a710fa
Compare
suzp1984
force-pushed
the
bugfix/srt-bridge-hevc-to-rtmp
branch
26 times, most recently
from
85334fa to
252510e
Compare
suzp1984
force-pushed
the
bugfix/srt-bridge-hevc-to-rtmp
branch
from
60dc9d0 to
64d692b
Compare
|
Feel free to upgrade dev-docker to FFmpeg 7 and Ubuntu 22/24. |
suzp1984
force-pushed
the
bugfix/srt-bridge-hevc-to-rtmp
branch
from
64d692b to
a21741c
Compare
suzp1984
force-pushed
the
bugfix/srt-bridge-hevc-to-rtmp
branch
from
a21741c to
08b3116
Compare
suzp1984
force-pushed
the
bugfix/srt-bridge-hevc-to-rtmp
branch
9 times, most recently
from
f64f0a1 to
765af57
Compare
try to fix ossrs#4428. Cause: rtmp do not support hevc, rtmp enhanced do.
suzp1984
force-pushed
the
bugfix/srt-bridge-hevc-to-rtmp
branch
from
765af57 to
05d8955
Compare
Root Cause: the ffmpeg 5, inside the docker image srs:ubuntu20-cache, do not support enhanced rtmp.
suzp1984
force-pushed
the
bugfix/srt-bridge-hevc-to-rtmp
branch
from
05d8955 to
1b67cf2
Compare
winlinvip
changed the title
winlinvip
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
try to fix #4428.
Cause
rtmp do not support hevc, rtmp enhanced do.
How to reproduce
./objs/srs -c conf/srt.confffmpeg -re -i ./doc/source.flv -c:v libx265 -crf 28 -preset medium -c:a copy -pes_payload_size 0 -f mpegts 'srt://127.0.0.1:10080?streamid=#!::r=live/livestream,m=publish'ffprobe rtmp://localhost/live/livestreamAbout the Failed BlackBox test
The failed blackbox test:
TestSlow_SrtPublish_RtmpPlay_HEVC_BasicTestSlow_SrtPublish_HttpFlvPlay_HEVC_BasicCause:
The ffmpeg 5 is used to record a piece of video (DRV), the ffmpeg will transcode the enhanced flv format to TS format, but ffmpeg 5 don't support enhanced rtmp (or flv) in this case.
The solution is to replace the ffmpeg to version 7 in those 2 test cases.
why not upgrade ffmpeg to version 7?
The black tests dependency on ffmpeg 5 will fail, and there are a few of them are not easy to resolve in ffmpeg 7.