feat(billing): update actions menu in my services page for us manager #18403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: #MANAGER-18779 Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
oalkabouss
requested review from
aottr,
MaximeBajeux,
JacquesLarique,
helabenkhalfallah,
anooparveti and
aboungnaseng-ovhcloud
and removed request for
a team
JacquesLarique
requested changes
Jul 31, 2025
...er/modules/billing-components/src/components/services-actions/services-actions.controller.js
Outdated
Show resolved
Hide resolved
...er/modules/billing-components/src/components/services-actions/services-actions.controller.js
Outdated
Show resolved
Hide resolved
Comment on lines
202
to
218
| return { | ||
| messages: errors, | ||
| state: errors.length > 0 ? 'PARTIAL' : 'OK', | ||
| }; |
There was a problem hiding this comment.
I don't think this give the same result as previously: here you'll always resolve the promise, when previously we were rejecting if there was any error
Comment on lines
187
to
191
| }).catch((err) => ({ | ||
| id: service.serviceId, | ||
| message: err, | ||
| type: 'ERROR', | ||
| })); |
There was a problem hiding this comment.
I don't think this give the same result as previously: here you'll always resolve the promise, when previously we were rejecting if there was any error
...er/modules/billing-components/src/components/services-actions/services-actions.controller.js
Outdated
Show resolved
Hide resolved
oalkabouss
force-pushed
the
feat/MANAGER-18779
branch
from
6c6704f to
42fd221
Compare
ref: #MANAGER-18779 Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
oalkabouss
force-pushed
the
feat/MANAGER-18779
branch
from
42fd221 to
c0a6b91
Compare
JacquesLarique
approved these changes
Aug 1, 2025
MaximeBajeux
approved these changes
Aug 1, 2025
oalkabouss
added a commit
that referenced
this pull request
Aug 26, 2025
…#18403) ref: #MANAGER-18779 Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
oalkabouss
added a commit
that referenced
this pull request
Sep 10, 2025
…#18403) ref: #MANAGER-18779 Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
oalkabouss
added a commit
that referenced
this pull request
Sep 12, 2025
…#18403) ref: #MANAGER-18779 Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
oalkabouss
added a commit
that referenced
this pull request
Sep 12, 2025
…#18403) ref: #MANAGER-18779 Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
oalkabouss
added a commit
that referenced
this pull request
Sep 12, 2025
…#18403) ref: #MANAGER-18779 Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
MaximeBajeux
pushed a commit
that referenced
this pull request
Sep 16, 2025
…#18403) ref: #MANAGER-18779 Signed-off-by: Omar ALKABOUSS MOUSSANA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #MANAGER-18779
Description
Ticket Reference: #MANAGER-18779
Additional Information