[feature/modular-localization] Modular localization

.swiftlint.yml

@@ -3,7 +3,7 @@ excluded:
     - ownCloudScreenshotsTests
     - external
 
-function_body_length: 100
+#function_body_length: 100
 # warning_threshold: 5
 # line_length:
 #  warning: 300
@@ -33,8 +33,10 @@ disabled_rules:
     - function_body_length
     - implicit_getter
     - computed_accessors_order
-    - unneeded_notification_center_removal
     - function_parameter_count
+    - comment_spacing
+    - unused_closure_parameter
+#   - unneeded_notification_center_removal
 custom_rules:
   empty_line_after_guard_statement:
     included: ".*\\.swift"

ownCloudAppFramework/Branding/Branding.h

@@ -51,6 +51,7 @@ typedef NSString* BrandingImageName NS_TYPED_EXTENSIBLE_ENUM;
 @property(assign,nonatomic,readonly) BOOL brandingPropertiesFromLocalFile;
 
 @property(strong,nullable,nonatomic,readonly) NSString *appName; //!< Custom app name
+@property(strong,nonatomic,readonly) NSString *appDisplayName; //!< Branded app name, drawing from .appName, .organizationName and OCAppIdentity, with "ownCloud" as fallback
 @property(strong,nullable,nonatomic,readonly) NSString *organizationName; //!< Custom organization name
 @property(strong,nullable,nonatomic,readonly) NSArray<BrandingFileImportMethod> *disabledImportMethods; //!< Disabled file import methods
 

ownCloudAppFramework/Branding/Branding.m

@@ -202,6 +202,9 @@ - (instancetype)init
 		{
 			[(id<BrandingInitialization>)self initializeSharedBranding];
 		}
+
+		// Set app.name localization variable to branded name
+		[OCLocaleFilterVariables.shared setVariable:@"app.name" value:self.appDisplayName];
 	}
 
 	return (self);
@@ -241,6 +244,17 @@ - (NSString *)organizationName
 	return ([self computedValueForClassSettingsKey:BrandingKeyOrganizationName]);
 }
 
+- (NSString *)appDisplayName
+{
+	NSString *appName;
+
+	if ((appName = self.appName) != nil) { return (appName); }
+	if ((appName = self.organizationName) != nil) { return (appName); }
+	if ((appName = OCAppIdentity.sharedAppIdentity.appDisplayName) != nil) { return (appName); }
+
+	return (@"ownCloud");
+}
+
 - (NSDictionary *)userDefaultsDefaultValues
 {
 	return ([self computedValueForClassSettingsKey:BrandingKeyUserDefaultsDefaultValues]);

ownCloudAppFramework/Branding/BrandingClassSettingsSource.m

@@ -25,6 +25,8 @@ + (void)load
 {
 	[OCClassSettings.sharedSettings insertSource:[BrandingClassSettingsSource new] before:OCClassSettingsSourceIdentifierManaged after:nil];
 	[Branding.sharedBranding registerUserDefaultsDefaults];
+
+	[OCLocaleFilterClassSettings.shared pullFromClassSettings];
 }
 
 - (OCClassSettingsSourceIdentifier)settingsSourceIdentifier

ownCloudAppShared/Foundation Extensions/String+Extension.swift

@@ -18,6 +18,7 @@
 
 import Foundation
 import UIKit
+import ownCloudSDK
 
 private let _sharedAppBundle = Bundle(identifier: "com.owncloud.ownCloudAppShared")
 
@@ -30,11 +31,11 @@ public extension Bundle {
 extension String {
 
 	public var localized: String {
-		return NSLocalizedString(self, comment: "")
+		return OCLocale.localize(self)
 	}
 
-	public var slocalized : String {
-		return NSLocalizedString(self, tableName: nil, bundle: Bundle.sharedAppBundle, value: self, comment: "")
+	public func localized(_ replacements: [ String : String ]) -> String {
+		return OCLocale.localize(self, options: [OCLocaleOptionKeyVariables : replacements])
 	}
 
 	public var isNumeric: Bool {

ownCloudAppShared/Tools/VendorServices.swift

@@ -68,15 +68,7 @@ public class VendorServices : NSObject {
 	}
 
 	public var appName: String {
-		if let appName = Branding.shared.appName {
-			return appName
-		}
-
-		if let organizationName = Branding.shared.organizationName {
-			return organizationName
-		}
-
-		return OCAppIdentity.shared.appDisplayName ?? "ownCloud"
+		return Branding.shared.appDisplayName
 	}
 
 	public var feedbackMail: String? {