Skip to content

Conversation

hosy
Copy link
Collaborator

@hosy hosy commented Dec 16, 2021

Description

Related Issue

#1079

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Added changelog files for the fixed issues in folder changelog/unreleased

hosy and others added 4 commits December 16, 2021 10:15
- added fastlane changelog
- added Calens changelog entry
…gistration errors (#1068)

* - update SDK to add support for authentication-oauth2.oidc-fallback-on-client-registration-failure, defaulting to true, to allow the automatic fallback to default client_id / client_secret if OpenID Connect Dynamic Client Registration fails with any error

* - fix infinite OAuth2 token refresh loop via SDK update
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ hosy
❌ felix-schwarz
You have signed the CLA already but the status is still pending? Let us recheck it.

hosy and others added 20 commits December 17, 2021 21:09
- changed changelog folder name
* - update SDK to add support for authentication-oauth2.oidc-fallback-on-client-registration-failure, defaulting to true, to allow the automatic fallback to default client_id / client_secret if OpenID Connect Dynamic Client Registration fails with any error

* - fix infinite OAuth2 token refresh loop via SDK update

* - BookmarkViewController: store user.displayName in .userDisplayName rather than .displayName
- OCBookmark+AppExtensions:
	- make .displayName readonly and mark it as legacy
	- return .userDisplayName for .displayName if the former has a value
- StaticLoginSingleAccountServerListViewController:
	- remove OCConnection code to fetch a user's display name and use bookmark.displayName instead
	- listen for bookmark updates and trigger a header update then accordingly
- update SDK to gain bookmark.userDisplayName support

* - update SDK to gain bookmark.userDisplayName support

Co-authored-by: Matthias Hühne <[email protected]>
* - update SDK to add support for authentication-oauth2.oidc-fallback-on-client-registration-failure, defaulting to true, to allow the automatic fallback to default client_id / client_secret if OpenID Connect Dynamic Client Registration fails with any error

* - fix infinite OAuth2 token refresh loop via SDK update

* - BookmarkViewController: store user.displayName in .userDisplayName rather than .displayName
- OCBookmark+AppExtensions:
	- make .displayName readonly and mark it as legacy
	- return .userDisplayName for .displayName if the former has a value
- StaticLoginSingleAccountServerListViewController:
	- remove OCConnection code to fetch a user's display name and use bookmark.displayName instead
	- listen for bookmark updates and trigger a header update then accordingly
- update SDK to gain bookmark.userDisplayName support

* - update SDK to gain bookmark.userDisplayName support

* Prevent unwanted connection following setup of the first account, preventing an immediate OCCore request and unclean return with possible instance overlap by starting the connection on the - at that time - already removed parent view controller.

* new build number

Co-authored-by: Matthias Hühne <[email protected]>
- updated release notes
- changed changelog folder name
- make SortMethod.comparator use OCSQLiteCollationLocalized.sortComparator
@hosy hosy merged commit 2524b7f into master Dec 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the milestone/11.8.1 branch December 22, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants