[fix/mac-drop-crash] Fix file drop crash on macOS #1461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s nil (f.ex. if no File Provider is available or included), fixing a crash on macOS when dragging a file into the app.
felix-schwarz
force-pushed
the
fix/mac-drop-crash
branch
from
6e1009b to
c0144d5
Compare
hosy
approved these changes
Apr 23, 2025
|
For this one, i guess i'd need a mac with Apple chip (mine is intel). Anyway, the code is easy and clear. If you tested it and worked, please move it forward. |
|
@jesmrec Indeed, that can only be tested on an Apple Silicon system. I'd love to move it forward but will need a second approving review to merge it. Could you add your approval? |
jesmrec
approved these changes
Apr 25, 2025
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a crash when using the iOS app on macOS and dropping a file onto the app's window to upload a file.
Types of changes