[fix/share-image-to-app] Fix screenshot/image sharing via Share Extension #1466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add support for saving NSExtensionItem.attachment of type "public.image" as png (like when using the iOS-provided "Save to Files"(.app) extension) - minor code style improvements - fixes owncloud/enterprise#7223
|
From my side this is OK. I will approve when the code review is done, just in case any change could cause a new QA round. |
Matthias-Huehne-Kiteworks
approved these changes
May 22, 2025
jesmrec
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for saving
NSExtensionItem.attachmentof typepublic.imageas png (like when using the iOS-provided "Save to Files"(.app) extension) toShareExtensionViewController.Related Issue
https://github.com/owncloud/enterprise/issues/7223
Types of changes