Skip to content

Conversation

hosy
Copy link
Collaborator

@hosy hosy commented Jul 3, 2019

Description

Give the user a feedback, when offline copies will be deleted

Related Issue

#393

Motivation and Context

Better user feedback

How Has This Been Tested?

Account > Manage > Delete Offline Copies
Activity Indicator should appear right beside "Delete Offline Copies"

Screenshots (if appropriate):

Activity-Indicator

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…es will be deleted to give the user a UI feedback
@hosy hosy requested a review from mneuwert July 3, 2019 08:54
@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #438 into milestone/1.1 will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@                Coverage Diff                @@
##           milestone/1.1     #438      +/-   ##
=================================================
+ Coverage          27.22%   27.22%   +<.01%     
=================================================
  Files                264      264              
  Lines              20031    19960      -71     
=================================================
- Hits                5453     5435      -18     
+ Misses             14578    14525      -53
Impacted Files Coverage Δ
...wnCloud/Bookmarks/BookmarkInfoViewController.swift 0% <0%> (ø) ⬆️
ownCloud/Bookmarks/BookmarkViewController.swift 80.99% <0%> (+1.96%) ⬆️
ownCloud/Client/ClientRootViewController.swift 68.09% <0%> (+2.77%) ⬆️
...ud/Server List/ServerListTableViewController.swift 70.83% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea6c365...9b4a828. Read the comment docs.

@hosy hosy requested a review from felix-schwarz July 8, 2019 22:20
@hosy hosy changed the base branch from master to milestone/1.1 July 10, 2019 10:40
@hosy hosy merged commit 9b4a828 into milestone/1.1 Jul 10, 2019
hosy added a commit that referenced this pull request Jul 10, 2019
Added an activity indicator for deleting offline copies #438
@delete-merged-branch delete-merged-branch bot deleted the fix/delete-offline-activity-indicator branch July 10, 2019 19:58
@jesmrec
Copy link
Contributor

jesmrec commented Jul 22, 2019

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved by QA Approved by QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants