Skip to content

Conversation

hosy
Copy link
Collaborator

@hosy hosy commented Jan 27, 2021

Description

This PR uses GitHub Actions to automatically generate a changelog file with Calens and commits the new CHANGELOG.md into the current branch.
Furthermore the PR template was updated with new checkboxes to get sure, that a release notes issue file for Calense was added.

Related Issue

Motivation and Context

Automatically changelog file creation, with the same structure, as other ownCloud repositories.

How Has This Been Tested?

  • Add an release notes issue file into changelog/unreleased with the issue number as file name
  • Commit and push to git
  • Check GitHub Actions
  • As a result the CHANGELOG.md file should be updated

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

hosy and others added 2 commits January 27, 2021 15:10
@hosy hosy requested review from TheOneRing, micbar and jesmrec January 27, 2021 14:24
@hosy hosy self-assigned this Jan 27, 2021
@hosy hosy added this to the 11.5.0-Current milestone Jan 27, 2021

jobs:
build:
runs-on: ubuntu-16.04
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it need to be that old? I think 16.04 is eol.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you prefer? 20.04?

Copy link
Contributor

@TheOneRing TheOneRing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog/CHANGELOG.md
I guess you copied it from desktop, that file was committed by accident 🙈

@hosy
Copy link
Collaborator Author

hosy commented Jan 27, 2021

changelog/CHANGELOG.md
I guess you copied it from desktop, that file was committed by accident 🙈

I used the file and folder structure from the client repo.

hosy added 2 commits January 27, 2021 15:39
- Using newer ubuntu version
- Removing unneeded file
…d/ios-app into feature/calens-changelog-actions
@hosy hosy requested a review from TheOneRing January 27, 2021 14:40
Copy link
Contributor

@TheOneRing TheOneRing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking god so far.

If you would like to take a look in ocis, we managed to do release and Full changelog with only a single template.

@micbar
Copy link
Contributor

micbar commented Feb 1, 2021

Do you use Calens in the release process?

We do that in ocis like this https://github.com/owncloud/ocis/blob/master/.drone.star#L914

It pushes the single version changes into gitHub releases.

https://github.com/owncloud/ocis/blob/master/.drone.star#L934

@hosy
Copy link
Collaborator Author

hosy commented Feb 1, 2021

@micbar thank you for your hint. Calens will be processed after each commit in the related branch.
I can have a look creating a GitHub release automatically, when a new tag was detected.

@hosy hosy merged commit 79eec1d into milestone/11.5 Feb 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the feature/calens-changelog-actions branch February 1, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants