fix: DynamicValue in high model schema missing N value #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 99.74% // Head: 99.74% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 136 136
Lines 7934 7934
=======================================
Hits 7914 7914
Misses 20 20
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
TristanSpeakEasy
approved these changes
Jan 21, 2023
|
Thank you for fixing it and for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a small issue while upgrading to the latest libopenapi. The new
DynamicValue.Nfield is not copied over from the low-level model, so for exampleschema.ExclusiveMinimum.IsB()will always returnfalse. This PR fixes it and adds a small test to assert the values get set. For the boolean case it is left alone asNwill default to zero.Note: this is important as the exclusive minimum can be zero, in which case it's currently not possible to determine whether a value was set or which one was set.
Sorry for the delay in upgrading BTW, I got side-tracked shipping https://rest.sh/#/bulk