PMM-11082 Fix infoSchemaInnodbMetricsEnabledColumnQuery performance #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The query introduced with prometheus#523 performs poorly when there are sufficient numbers of columns in information_schema.columns. * Added using the table_schema as a filter * Added limit to the query
cezmunsta
requested review from
floatinginbits and
tshcherban
and removed request for
a team
|
|
JiriCtvrtka
approved these changes
Nov 29, 2022
tshcherban
approved these changes
Nov 30, 2022
ritbl
reviewed
Dec 5, 2022
Comment on lines
+34
to
+37
| WHERE table_schema = 'information_schema' | ||
| AND table_name = 'INNODB_METRICS' | ||
| AND column_name IN ('status', 'enabled') | ||
| LIMIT 1 |
There was a problem hiding this comment.
It looks as a workaround. I think for future us, we need at least document reasons for this change.
Here are a few points that are not clear:
1: why LIMIT 1?
2: it looks like schema was changed. this check for table_schema is the same across all supported version?
denisok
pushed a commit
that referenced
this pull request
Dec 6, 2022
…106) The query introduced with prometheus#523 performs poorly when there are sufficient numbers of columns in information_schema.columns. * Added using the table_schema as a filter * Added limit to the query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query introduced with prometheus#523 performs poorly when there are sufficient numbers of columns in information_schema.columns.
table_schemaas a filterlimitto the queryPMM-11082
SUBMODULE-2924
Upstream PR