Skip to content

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Jun 25, 2025

What is changed, added or deleted? (Required)

Modified telemetry related doc files. Ref link pingcap/tidb#61753

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added the missing-translation-status This PR does not have translation status info. label Jun 25, 2025
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 25, 2025
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 25, 2025
@Oreoxmt Oreoxmt self-assigned this Jul 15, 2025
@Oreoxmt Oreoxmt added translation/doing This PR’s assignee is translating this PR. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. labels Jul 15, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jul 15, 2025
@Oreoxmt Oreoxmt added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Jul 15, 2025
@Oreoxmt Oreoxmt mentioned this pull request Jul 15, 2025
14 tasks
@Oreoxmt Oreoxmt self-requested a review July 15, 2025 08:24
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jul 15, 2025

@Defined2014 I've added some feedback in the review comments #20556 (review). After you've had a chance to address those, could you please invite a tech reviewer to take a look?

@Defined2014 Defined2014 requested a review from bb7133 July 15, 2025 08:58
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 15, 2025
@hfxsd hfxsd self-requested a review July 17, 2025 07:18
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 17, 2025
Copy link

ti-chi-bot bot commented Jul 17, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-15 09:05:34.253564483 +0000 UTC m=+2595386.976743462: ☑️ agreed by Oreoxmt.
  • 2025-07-17 10:02:54.361887112 +0000 UTC m=+2771627.085066093: ☑️ agreed by hfxsd.

@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 18, 2025
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Aug 8, 2025

@bb7133: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Aug 14, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2025
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Aug 14, 2025

/approve

Copy link

ti-chi-bot bot commented Aug 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 14, 2025
@ti-chi-bot ti-chi-bot bot merged commit 6f19fde into pingcap:master Aug 14, 2025
6 of 7 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20780.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants