Skip to content
This repository was archived by the owner on Jan 3, 2025. It is now read-only.

Conversation

Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Jun 20, 2022

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Close #910

Which DM version(s) do your changes apply to? (Required)

Since December 23, 2021, the TiDB DM documentation in the master branch has been merged to TiDB documentation by #8042 and #7317. To create a PR for TiDB DM versions later than v5.3, either go to TiDB English documentation repository or Chinese documentation repository.

  • v5.3 (TiDB DM 5.3 versions)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added translation/no-need The changes in this PR don't need to be translated. needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. labels Jun 20, 2022
@Oreoxmt Oreoxmt requested a review from ran-huang June 20, 2022 03:08
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 20, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ran-huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 20, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 20, 2022
@ran-huang ran-huang added the require-LGT1 Indicates that the PR requires an LGTM. label Jun 20, 2022
@ran-huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2072907

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 20, 2022
@ti-chi-bot ti-chi-bot merged commit 1025229 into pingcap:master Jun 20, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #912.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #913.

ti-chi-bot added a commit that referenced this pull request Jun 20, 2022
ti-chi-bot added a commit that referenced this pull request Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-release-2.0 Should cherry pick this PR to release-2.0 branch. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/no-need The changes in this PR don't need to be translated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: Verify internal link anchors costs 13min
3 participants