-
Notifications
You must be signed in to change notification settings - Fork 703
op-guide, tikv: update tidb and tikv docker compose steps #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
01fe0af
op-guide: move buildFrom to buildPath for docker compose guide
lilin90 333a615
op-guide: modify yaml to yml
lilin90 2184ed5
op-guide: address comments
lilin90 3ba490e
op-guide: update wording to address the comment
lilin90 cf62a04
tikv: improve code
lilin90 a36f6bb
op-guide: update `vim` in TiDB docker compose
lilin90 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -85,24 +85,22 @@ To customize the cluster, you can edit the `docker-compose.yml` file directly. I | |
|
||
```bash | ||
cd tidb-docker-compose | ||
cp compose/values.yaml values.yaml | ||
vim values.yaml | ||
vi compose/values.yaml # custom the cluster size, docker image, port mapping and so on | ||
``` | ||
|
||
You can modify the configuration in `values.yaml`, such as the cluster size, TiDB image version, and so on. | ||
|
||
[tidb-vision](https://github.com/pingcap/tidb-vision) is the data visualization interface of the TiDB cluster, used to visually display the PD scheduling on TiKV data. If you do not need this component, leave `tidbVision` empty. | ||
[tidb-vision](https://github.com/pingcap/tidb-vision) is the data visualization interface of the TiDB cluster, used to visually display the PD scheduling on TiKV data. If you do not need this component, comment out the `tidbVision` field. | ||
|
||
|
||
For PD, TiKV, TiDB and tidb-vision, you can build Docker images from GitHub source code or local files for development and testing. | ||
|
||
- To build the image of a component from GitHub source code, you need to leave the `image` field empty and set `buildFrom` to `remote`. | ||
- To build PD, TiKV or TiDB images from the locally compiled binary file, you need to leave the `image` field empty, set `buildFrom` to `local` and copy the compiled binary file to the corresponding `pd/bin/pd-server`, `tikv/bin/tikv-server`, `tidb/bin/tidb-server`. | ||
- To build the tidb-vision image from local, you need to leave the `image` field empty, set `buildFrom` to `local` and copy the tidb-vision project to `tidb-vision/tidb-vision`. | ||
- To build PD, TiKV or TiDB images from the locally compiled binary file, you need to comment out the `image` field and copy the compiled binary file to the corresponding `pd/bin/pd-server`, `tikv/bin/tikv-server`, `tidb/bin/tidb-server`. | ||
- To build the tidb-vision image from local, you need to comment out the `image` field and copy the tidb-vision project to `tidb-vision/tidb-vision`. | ||
|
||
4. Generate the `docker-compose.yml` file. | ||
|
||
```bash | ||
helm template -f values.yaml compose > generated-docker-compose.yml | ||
helm template compose > generated-docker-compose.yml | ||
``` | ||
|
||
5. Create and start the cluster using the generated `docker-compose.yml` file. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other guides we use
vim
, for some users on some older systems they may getvi
instead ofvim
if they typevi
, which could lead to some confusion.