-
Notifications
You must be signed in to change notification settings - Fork 229
chore: add prow OWNERS file #1231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6b45e4f
chore: add prow OWNERS file
wuhuizuo fa350b8
Merge branch 'master' into ci/add-owners-files
wuhuizuo fae2c04
chore: update OWNERS files
wuhuizuo f0982ee
chore: add default approvers for other folders
wuhuizuo 644d774
ci: ignore OWNERS file for protolock commands
wuhuizuo d9846b0
ci: fix build.rs
wuhuizuo 5037f18
ci: fix check.sh
wuhuizuo 36006a0
Update OWNERS_ALIASES
wuhuizuo 594d978
Update proto/OWNERS
wuhuizuo c8b18a3
Update OWNERS_ALIASES
wuhuizuo 170a380
Update proto/OWNERS
wuhuizuo dd951a0
chore: update OWNERS for proto files
wuhuizuo 4303764
Merge branch 'master' into ci/add-owners-files
wuhuizuo 16101f4
chore: update OWNERS for `import_*pb.proto` files
wuhuizuo 5df05b8
Merge branch 'master' into ci/add-owners-files
wuhuizuo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
# See the OWNERS docs at https://go.k8s.io/owners | ||
approvers: | ||
- sig-approvers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# Sort the member alphabetically. | ||
aliases: | ||
sig-approvers: # default approvers for the repo on rest folders. | ||
- cfzjywxk | ||
- lance6716 | ||
- overvenus | ||
- you06 | ||
- YuJuncen | ||
sig-approvers-pb: # default approvers for `proto` folder | ||
- kevin-xialiu | ||
- yudongusa | ||
- zhangjinpeng1987 | ||
sig-approvers-pb-autoid: [bb7133, tiancaiamao] | ||
sig-approvers-pb-br: [BornChanger] | ||
sig-approvers-pb-cdc: [flowbehappy] | ||
sig-approvers-pb-coprocessor: [cfzjywxk] | ||
sig-approvers-pb-deadlock: [MyonKeminta, cfzjywxk] | ||
sig-approvers-pb-debug: [cfzjywxk] | ||
sig-approvers-pb-raftstore: [tonyxuqqi, overvenus] | ||
sig-approvers-pb-tikv: [tonyxuqqi] | ||
sig-approvers-pb-error: [cfzjywxk] | ||
sig-approvers-pb-kvrpc: [cfzjywxk] | ||
sig-approvers-pb-trace: [you06] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
# See the OWNERS docs at https://go.k8s.io/owners | ||
options: | ||
no_parent_owners: true | ||
filters: | ||
"^autoid\\.proto$": | ||
approvers: [sig-approvers-pb-autoid] | ||
"^brpb\\.proto$": | ||
approvers: [sig-approvers-pb-br] | ||
"^cdcpb\\.proto$": | ||
approvers: [sig-approvers-pb-cdc] | ||
"^coprocessor\\.proto$": | ||
approvers: [sig-approvers-pb-coprocessor] | ||
"^deadlock\\.proto$": | ||
approvers: [sig-approvers-pb-deadlock] | ||
"^debugpb\\.proto$": | ||
approvers: [sig-approvers-pb-debug] | ||
"^disk_usage\\.proto$": | ||
approvers: [sig-approvers-pb-raftstore] | ||
"^errorpb\\.proto$": | ||
approvers: [sig-approvers-pb-error] | ||
"^encryptionpb\\.proto$": | ||
approvers: [sig-approvers-pb-raftstore] | ||
"^import_kvpb\\.proto$": | ||
approvers: [sig-approvers-pb-br] | ||
"^import_sstpb\\.proto$": | ||
approvers: [sig-approvers-pb-br] | ||
"^kvrpcpb\\.proto$": | ||
approvers: [sig-approvers-kvrpc] | ||
"^logbackuppb\\.proto$": | ||
approvers: [sig-approvers-pb-br] | ||
"^metapb\\.proto$": | ||
approvers: [sig-approvers-pb-raftstore] | ||
"^raft_cmdpb\\.proto$": | ||
approvers: [sig-approvers-pb-raftstore] | ||
"^raft_serverpb\\.proto$": | ||
approvers: [sig-approvers-pb-raftstore] | ||
"^recoverdatapb\\.proto$": | ||
approvers: [sig-approvers-pb-br] | ||
"^resource_manager\\.proto$": | ||
approvers: [sig-approvers-pb-raftstore] | ||
"^tikvpb\\.proto$": | ||
approvers: [sig-approvers-pb-tikv, sig-approvers-pb-kvprc] | ||
"^tracepb\\.proto$": | ||
approvers: [sig-approvers-pb-trace] | ||
|
||
### If the special file need to be controlled by a SIG, please uncomment it and fill the approvers. | ||
# "^configpb\\.proto$": | ||
# approvers: [] | ||
# "^diagnosticspb\\.proto$": | ||
# approvers: [] | ||
# "^disaggregated\\.proto$": | ||
# approvers: [] | ||
# "^enginepb\\.proto$": | ||
# approvers: [] | ||
# "^gcpb\\.proto$": | ||
# approvers: [] | ||
# "^keyspacepb\\.proto$": | ||
# approvers: [] | ||
# "^meta_storagepb\\.proto$": | ||
# approvers: [] | ||
# "^mpp\\.proto$": | ||
# approvers: [] | ||
# "^pdpb\\.proto$": | ||
# approvers: [] | ||
wuhuizuo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
# "^replication_modepb\\.proto$": | ||
# approvers: [] | ||
# "^resource_usage_agent\\.proto$": | ||
# approvers: [] | ||
# "^schedulingpb\\.proto$": | ||
# approvers: [] | ||
# "^tsopb\\.proto$": | ||
# approvers: [] | ||
|
||
# For rest files. | ||
".*": | ||
approvers: [sig-approvers-pb] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,15 +20,20 @@ check-protos-compatible() { | |
export PATH=$GOPATH/bin:$PATH | ||
|
||
if [ ! -f "$GOPATH/bin/protolock" ]; then | ||
GO111MODULE=off go install github.com/nilslice/protolock/cmd/[email protected] | ||
go install github.com/nilslice/protolock/cmd/[email protected] | ||
fi | ||
which protolock || { | ||
echo "not found protolock in PATH." | ||
ls -l "$GOPATH/bin/protolock" | ||
wuhuizuo marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
exit 1 | ||
} | ||
|
||
if protolock status -lockdir=scripts -protoroot=proto; then | ||
protolock commit -lockdir=scripts -protoroot=proto | ||
if protolock status -lockdir=scripts -protoroot=proto --ignore=OWNERS; then | ||
protolock commit -lockdir=scripts -protoroot=proto --ignore=OWNERS | ||
else | ||
echo "Meet break compatibility problem, please check the code." | ||
# In order not to block local branch development, when meet break compatibility will force to update `proto.lock`. | ||
protolock commit --force -lockdir=scripts -protoroot=proto | ||
protolock commit --force -lockdir=scripts -protoroot=proto --ignore=OWNERS | ||
fi | ||
# git report error like "fatal: detected dubious ownership in repository at" when reading the host's git folder | ||
git config --global --add safe.directory $(pwd) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.