Skip to content

Conversation

wk989898
Copy link
Collaborator

@wk989898 wk989898 commented Jun 27, 2025

What problem does this PR solve?

Issue Number: ref #442

What is changed and how it works?

  1. Add failpoint about kafka and pulsar
  2. Fix script bug
  3. Add status api

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

Copy link

ti-chi-bot bot commented Jun 27, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 27, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @wk989898, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on improving the reliability and coverage of our integration tests by fixing incorrect failpoint injection paths and introducing new failpoint capabilities. The changes ensure that our test suite can more accurately simulate various error and delay conditions within the Kafka and MySQL sinks, leading to more robust testing of error handling and recovery mechanisms.

Highlights

  • Failpoint Path Correction: I've corrected the module paths for several existing failpoint injections in various integration test scripts (e.g., capture_session_done_during_task/run.sh, consistent_partition_table/run.sh, kafka_sink_error_resume/run.sh, etc.). These changes update the paths from github.com/pingcap/tiflow/cdc/... to the correct github.com/pingcap/ticdc/... to ensure failpoints are properly triggered during testing.
  • New Kafka Sink Failpoint: I've introduced a new failpoint, KafkaSinkAsyncSendError, within the Kafka sink's sendMessages function (lines 410-417 in downstreamadapter/sink/kafka/sink.go). This failpoint allows for simulating an error during the asynchronous sending of messages to Kafka, specifically after the message is accepted by the producer but before it's successfully flushed, enhancing test coverage for error recovery scenarios.
  • New MySQL Sink Failpoint: I've added a new failpoint, MySQLSinkExecDDLDelay, to the execDDL function in the MySQL DDL writer (lines 65-71 in pkg/sink/mysql/mysql_writer_ddl.go). This failpoint can be used to inject a delay during DDL execution, which is useful for testing scenarios where DDL operations might hang or take a long time.
  • Kafka Sink Refactoring: I've removed the adminClient field from the sink struct in downstreamadapter/sink/kafka/sink.go (line 47). This field was no longer necessary for the sink's operations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes incorrect failpoint injection paths across several integration tests. The changes in the shell scripts correctly update the paths from tiflow/cdc to ticdc. There was a critical issue with the new KafkaSinkAsyncSendError failpoint implementation in the Kafka sink, where an error is sent to a channel that is never read from, which will cause the sink to hang. This has been addressed in the review comments.

@wk989898 wk989898 marked this pull request as ready for review June 27, 2025 07:14
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 27, 2025
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 27, 2025
@wk989898 wk989898 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 30, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 30, 2025
Copy link

ti-chi-bot bot commented Jun 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jun 30, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-06-30 05:55:27.398896048 +0000 UTC m=+1287980.122075027: ☑️ agreed by 3AceShowHand.

@ti-chi-bot ti-chi-bot bot added the approved label Jun 30, 2025
Copy link

ti-chi-bot bot commented Jun 30, 2025

@wk989898: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-pulsar-integration-light 54fd1e2 link false /test pull-cdc-pulsar-integration-light

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@wk989898
Copy link
Collaborator Author

wk989898 commented Jul 1, 2025

/test pull-cdc-kafka-integration-heavy

@wk989898 wk989898 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2025
@ti-chi-bot ti-chi-bot bot merged commit afbc560 into pingcap:master Jul 1, 2025
14 of 15 checks passed
@wk989898 wk989898 deleted the test-failpoints branch July 1, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants