Introduce keyspace and refactor API, CLI, and internal components to replace namespace. #1768
Conversation
ti-chi-bot
bot
added
release-note
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @tenfyzhong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refactors the TiCDC codebase to replace the term "namespace" with "keyspace ID" for changefeed identification. This change aims to enhance terminology clarity and consistency across API endpoints, internal data structures, and etcd keys, aligning with common distributed system concepts and avoiding ambiguity.
Highlights
- API Changes: The API parameter namespace has been replaced with keyspace_id across all relevant v2 changefeed endpoints (e.g., Create, List, Get, Delete, Pause, Resume, Update, MoveTable). A new query parameter APIOpVarKeyspaceID was introduced, and the internal GetNamespaceValueWithDefault function was renamed to GetKeyspaceValueWithDefault.
- Core Terminology Refactoring: common.DefaultNamespace is now common.DefaultKeyspaceID. The Namespace field in common.ChangeFeedDisplayName has been renamed to KeyspaceID, and all related constructors and accessors for common.ChangeFeedID and common.ChangeFeedDisplayName have been updated to reflect this.
- Coordinator Logic: The coordinator.Controller.ListChangefeeds method now accepts a keyspace parameter, leveraging a newly added ChangefeedDB.GetAllChangefeedsByKeyspace method to filter changefeeds by their keyspace.
- Etcd Key Management: Etcd key prefixes and generation functions have been updated from NamespacedPrefix to KeyspaceIDPrefix and now use the new KeyspaceID terminology for changefeed information, status, and task positions.
- Data Migration: Logic in pkg/migrate has been adjusted to ensure seamless transition of existing changefeed data from the old "namespace" concept to the new "keyspace" concept in etcd, maintaining backward compatibility.
- Internal Components & Testing: Redo log file naming has been updated to use common.DefaultKeyspaceID, and extensive unit and integration tests across various packages have been modified to align with the new KeyspaceID terminology and API changes.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request does a great job of standardizing the terminology from 'namespace' to 'keyspace ID' across a large part of the codebase. The changes are extensive and touch many components, including APIs, internal data structures, etcd keys, and tests. The migration logic for existing data is also a crucial part of this change.
My review focuses on ensuring consistency in the new terminology, removing redundant code introduced during the refactoring, and fixing a couple of issues with metrics labeling. Overall, the changes are well-executed and move the codebase in the right direction for clarity and consistency.
|
/retest-required |
1 similar comment
|
/retest-required |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request standardizes the terminology by replacing 'namespace' with 'keyspace ID' across the codebase, which improves clarity and consistency. The changes are extensive, touching APIs, internal data structures, and etcd keys. The refactoring is well-executed.
I've found one critical issue in the new KeyspaceCheckerMiddleware that could cause requests for the default keyspace to hang. I've also pointed out a minor inconsistency in a JSON tag for the new Keyspace field. Overall, great work on this significant refactoring.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tenfyzhong
changed the title
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request is a large-scale refactoring to replace "namespace" with "keyspace" throughout the codebase, which is a significant step towards clearer terminology. The changes are extensive and appear to be applied consistently. The introduction of the KeyspaceCheckerMiddleware is a valuable addition for API robustness. My review has identified a few areas for improvement, primarily concerning error handling in the new middleware, simplifying logic in API handlers for better clarity, and ensuring consistency in CLI flags.
| } | ||
|
|
||
| if meta.State != keyspacepb.KeyspaceState_ENABLED { | ||
| c.IndentedJSON(http.StatusBadRequest, errors.ErrAPIInvalidParam) |
There was a problem hiding this comment.
The error errors.ErrAPIInvalidParam is too generic. When a keyspace is not enabled, providing a more specific error message would improve the user experience. Consider generating a more descriptive error message.
| c.IndentedJSON(http.StatusBadRequest, errors.ErrAPIInvalidParam) | |
| c.IndentedJSON(http.StatusBadRequest, errors.ErrAPIInvalidParam.GenWithStack("keyspace %s is not enabled, state: %s", keyspace, meta.State.String())) |
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
tenfyzhong
force-pushed
the
feat-keyspace-for-api
branch
2 times, most recently
from
2d2efd6 to
599b19c
Compare
|
/retest-required |
1 similar comment
|
/retest-required |
- Rename the API query parameter for specifying a changefeed's namespace from `namespace` to `keyspace_id`. - Update the `CreateChangefeed` handler to retrieve the namespace value using `keyspace_id`. - Modify `common.NewChangefeedID` and `common.NewChangeFeedIDWithName` to accept a namespace parameter, defaulting to `DefaultNamespace` if not provided. Signed-off-by: tenfyzhong <[email protected]>
- Allow users to list changefeeds specific to a given keyspace. - Enhance the API to provide more granular control when retrieving changefeeds. - Update the coordinator, controller, and changefeed database to support keyspace-aware listing. Signed-off-by: tenfyzhong <[email protected]>
…eWithDefault - Renamed `GetNamespaceValueWithDefault` function to `GetKeyspaceValueWithDefault` to improve clarity and consistency with the `keyspace` terminology used in the API. - Updated all call sites of the renamed function in `api/v2/changefeed.go`. - The internal variable `namespace` within the function was also renamed to `keyspaceID`. Signed-off-by: tenfyzhong <[email protected]>
- The constant `common.DefaultNamespace` has been renamed to `common.DefaultKeyspaceID`. - This change improves clarity and consistency by using a more precise term for the default logical grouping of changefeeds. - All references to the old constant have been updated across the codebase. Signed-off-by: tenfyzhong <[email protected]>
- The term "namespace" is being replaced by "keyspace ID" to better reflect the underlying concept. - Renamed the `NamespacedPrefix` function to `KeyspaceIDPrefix`. - Renamed the `namespace` parameter to `keyspaceID` in the `KeyspaceIDPrefix` function. - Updated all references and call sites to use the new function name and parameter. Signed-off-by: tenfyzhong <[email protected]>
…mands - Updated terminology for replication tasks to use "keyspace" instead of "namespace". - Aligned CLI flags (e.g., `--namespace` to `--keyspace`) and internal variables with the new "keyspace" term. - Changed the short flag from `-n` to `-k` for most changefeed commands to reflect the new name. Signed-off-by: tenfyzhong <[email protected]>
…ntegration tests - Update JSON payloads for changefeed creation and updates to use `keyspace`. - Modify query parameters in API requests (GET, POST, PUT, DELETE) from `namespace` to `keyspace`. - Rename `Namespace` fields to `Keyspace` in API v2 model structs (`ChangefeedCommonInfo`, `ChangefeedConfig`, `ProcessorCommonInfo`, `ChangeFeedInfo`). - Update `tableInfo` struct and its usage in `move_table` integration tests to reflect the terminology change. Signed-off-by: tenfyzhong <[email protected]>
- Removed specific author and date metadata from a code comment. - Cleans up the comment by removing unnecessary and potentially outdated internal tracking information. Signed-off-by: tenfyzhong <[email protected]>
…essages - Standardize terminology by replacing `keyspace_id` with `keyspace`. - Improve clarity and consistency in error messages and code comments. Signed-off-by: tenfyzhong <[email protected]>
- The JSON tag for the `Keyspace` field was `Keyspace`. - This change aligns it with common JSON naming conventions by making the first letter lowercase (`keyspace`). - Ensures consistent API representation for change feed display names. Signed-off-by: tenfyzhong <[email protected]>
- Implement the `LoadKeyspace` method for the `mockPDAPIClient` to support new testing scenarios. Signed-off-by: tenfyzhong <[email protected]>
- The previous condition `changefeed.ChangefeedID.Keyspace() != keyspace` caused incorrect filtering behavior. - Specifically, when the `keyspace` query parameter was empty (implying "all keyspaces"), it would incorrectly filter out changefeeds that had any keyspace assigned. - This change ensures that `ListChangeFeeds` returns all changefeeds matching the state, irrespective of their keyspace, when no specific keyspace is provided. - If specific keyspace filtering is desired, it should be implemented with a conditional check for a non-empty `keyspace` parameter. Signed-off-by: tenfyzhong <[email protected]>
- The previous short flag '-n' could conflict with 'name' or 'namespace' in other commands. - '-k' is more intuitive and consistent for 'keyspace'. Signed-off-by: tenfyzhong <[email protected]>
- The `keyspace` variable, derived from the API endpoint's path, is now used to set the changefeed's keyspace when `cfg.Keyspace` is empty. - This ensures the changefeed is created within the keyspace specified in the API request path, rather than falling back to a hardcoded default. - Removed the explicit assignment of `changefeedID.DisplayName.Keyspace` as it is implicitly handled or derived from `changefeedID.Keyspace()`. Signed-off-by: tenfyzhong <[email protected]>
- The keyspace for a new changefeed can now be specified using a `keyspace` query parameter. - This query parameter will take precedence over any keyspace provided in the request body. - Updated OpenAPI specification to reflect the new `keyspace` query parameter. Signed-off-by: tenfyzhong <[email protected]>
- Renamed `CalculateGCSafepoint` to `CalculateGlobalGCSafepoint` to clarify its global scope. - Added `CalculateKeyspaceGCBarrier` to compute the minimum checkpoint timestamp for each keyspace. - Implemented `TryUpdateKeypsaceGCBarrier` in `gcManager` and `SetGCBarrier` to update GC barriers for individual keyspaces. - Updated coordinator logic to support keyspace-specific GC barrier updates, conditionally enabling it for future keyspace management. - Added `ErrUpdateGCBarrierFailed` and `ErrLoadKeyspaceFailed` for keyspace GC operations. - This change enables more granular GC control by allowing different keyspaces to have independent GC barriers. Signed-off-by: tenfyzhong <[email protected]>
- Update `github.com/pingcap/tidb` to the latest version to incorporate recent fixes and features.
- Adapt to `tidb` API changes, including:
- Moving `infosync` package to `serverinfo`.
- Relocating `ddl.JobTableID` and `ddl.HistoryTableID` to `metadef`.
- Shifting `session.SetSchemaLease` to `vardef.SetSchemaLease`.
- Update various other Go module dependencies to their latest compatible versions.
Signed-off-by: tenfyzhong <[email protected]>
- Run `go mod tidy` to remove entries for unused or outdated dependencies. Signed-off-by: tenfyzhong <[email protected]>
- The `TryUpdateKeypsaceGCBarrier` function now accepts `keyspaceName` to facilitate per-keyspace metric labeling. - Introduced `min_gc_barrier` and `cdc_gc_barrier` Prometheus gauges. - These gauges track the minimum and CDC GC barriers for each keyspace, labeled by the keyspace's name. - This provides better observability into the GC progress and barriers for individual keyspaces. Signed-off-by: tenfyzhong <[email protected]>
…g upgrades - Ensures that `ChangefeedID` can be correctly constructed from heartbeat messages sent by older version nodes. - If `pb.Keyspace` is empty (indicating an older node), `DisplayName.Keyspace` will fall back to using `pb.Namespace`. - This prevents issues when upgrading, maintaining compatibility with existing deployments. Signed-off-by: tenfyzhong <[email protected]>
- Update comment to explain that the `Namespace` field is preserved for backward compatibility during upgrades, mapping to `Keyspace`. Signed-off-by: tenfyzhong <[email protected]>
- Remove `namespace` field from `heartbeatpb.ChangefeedID` proto message. - Update `keyspace` field tag from `5` to `4` in `heartbeatpb.ChangefeedID`. - Remove corresponding `Namespace` field and its logic from generated Go code. - Remove `Namespace` cloning logic in `coordinator/changefeed.go`. - Remove backward compatibility logic for `Namespace` in `pkg/common/types.go`. - Simplifies the ChangefeedID structure by removing a redundant and deprecated field. Signed-off-by: tenfyzhong <[email protected]>
- Previously, a non-existent keyspace would result in a 500 Internal Server Error. - This change introduces a specific check for `ENTRY_NOT_FOUND` errors when loading keyspaces. - If a keyspace does not exist, the API now returns a `400 Bad Request` with `ErrAPIInvalidParam`. - This improves API clarity by distinguishing between internal server errors and invalid user input. - A new helper function `IsKeyspaceNotExistError` was added to `pkg/errors` for this check. Signed-off-by: tenfyzhong <[email protected]>
- Introduce `KeyspaceCheckerMiddleware` to validate keyspace access for all changefeed API endpoints. - This ensures that changefeed operations are restricted to the keyspace from which the request originated, enhancing security and data isolation. Signed-off-by: tenfyzhong <[email protected]>
… API - The `Create` changefeed API now requires the `keyspace` as a separate argument. - The `keyspace` is included as a query parameter in the HTTP POST request to the `/changefeeds` endpoint. - This change ensures the API call explicitly specifies the target keyspace for changefeed creation. - Updated the CLI command and mock interface to align with the new API signature. Signed-off-by: tenfyzhong <[email protected]>
- Use `common.DefaultKeyspace` for the default value of the `--keyspace` flag in `cdc cli` commands. - Pass the keyspace explicitly to the `VerifyTable` API method. - Replace hardcoded "keyspace" query parameter strings with `api.APIOpVarKeyspace` constant in API calls for consistency. Signed-off-by: tenfyzhong <[email protected]>
- Improve error message clarity by including the request URI when a keyspace does not exist. - This provides more context for debugging `KeyspaceNotExistError` cases. Signed-off-by: tenfyzhong <[email protected]>
- Revert to using the global GC safepoint update mechanism. - The next-gen keyspace GC barrier feature is not yet ready. Signed-off-by: tenfyzhong <[email protected]>
…equest URI" This reverts commit 67f2ae4.
tenfyzhong
force-pushed
the
feat-keyspace-for-api
branch
from
6ede9bd to
e24a793
Compare
- Activate next-gen GC barrier updates by checking `kerneltype.IsNextGen()`. - Remove placeholder `TODO` comments for next-gen GC feature. Signed-off-by: tenfyzhong <[email protected]>
- The `ObjPrefix` was incorrectly prepended with `subDir`, leading to a redundant and incorrect path prefix when combined with the `SubDir` option in `WalkDir`. - This ensures that `WalkDir` correctly searches for schema files within the specified `subDir` by using a relative prefix. Signed-off-by: tenfyzhong <[email protected]>
Signed-off-by: tenfyzhong <[email protected]>
- The `common.NewChangeFeedIDWithName` function now requires a keyspace parameter. - Updated all test calls to use `common.DefaultKeyspace` to align with the new API signature. - Moved the `LoadKeyspace` mock implementation to `testutil.MockPDAPIClient` for centralization. Signed-off-by: tenfyzhong <[email protected]>
|
@tenfyzhong: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #1755
This PR primarily addresses two main areas:
keyspaceparameter in API requests, ensuring that only valid andENABLEDkeyspaces are processed, thus enhancing the API's reliability and user experience.What is changed and how it works?
This PR introduces a significant refactoring to replace the term "namespace" with "keyspace" across the TiCDC codebase to enhance clarity and consistency, and adds a keyspace validation middleware.
Core Terminology Renaming:
namespacefield inheartbeatpb.ChangefeedIDis now deprecated, and a newkeyspacefield has been added.common.DefaultNamespacehas been renamed tocommon.DefaultKeyspace.Namespacefield incommon.ChangeFeedDisplayNamehas been renamed toKeyspace.common.ChangeFeedIDandcommon.ChangeFeedDisplayName(e.g.,NewChangefeedID,NewChangeFeedIDWithName,NewChangefeedID4Test,Namespace()) have been updated to reflect theKeyspacechange and useKeyspace().ValidateNamespacefunction has been renamed toValidateKeyspace, and its associated regular expression (namespaceRe) and maximum length constant (namespaceMaxLen) have been updated tokeyspaceReandkeyspaceMaxLen.errors.ErrInvalidNamespacehas been renamed toerrors.ErrInvalidKeyspace.API Endpoint Updates (
api/v1/api.go,api/v2/changefeed.go,pkg/api/util.go):api.APIOpVarNamespacehas been renamed toapi.APIOpVarKeyspace.GetNamespaceValueWithDefaultfunction has been renamed toGetKeyspaceValueWithDefault.CreateChangefeed,ListChangefeeds,GetChangeFeed,DeleteChangefeed,PauseChangefeed,ResumeChangefeed,UpdateChangefeed,MoveTable,MoveSplitTable,SplitTableByRegionCount,MergeTable,ListTables,getDispatcherCount,status,syncState) now useGetKeyspaceValueWithDefault(c)instead ofGetNamespaceValueWithDefault(c).namespacetokeyspace.api/v1/api.go,api/v2/model.go,tests/integration_tests/api_v2/model.go) such asChangefeedConfig.Namespace,ChangefeedCommonInfo.Namespace,ProcessorCommonInfo.Namespace, andChangeFeedInfo.Namespacehave been renamed toKeyspace.pkg/api/v2/changefeed.goandpkg/api/v2/processor.gonow correctly usekeyspaceparameters.CLI Tooling Updates (
cmd/cdc/cli/*):cdc clicommands (e.g.,create,list,pause,resume,remove,query,update,move-table,merge-table,split-table-by-region-count) have updated their flags and internal variables fromnamespacetokeyspace.Coordinator Logic Adjustments:
coordinator.Controller.ListChangefeedsnow accepts akeyspaceparameter and usesChangefeedDB.GetAllChangefeedsByKeyspaceto filter changefeeds.ChangefeedDB.GetAllChangefeedsByKeyspace(keyspace string)has been added to retrieve changefeeds specific to a given keyspace.coordinator.Controller.calculateGCSafepointhas been renamed tocalculateGlobalGCSafepoint.coordinator.Controller.calculateKeyspaceGCBarrierhas been added to calculate keyspace-specific GC barriers.coordinator.coordinator.updateGCSafepointnow conditionally callsupdateGlobalGcSafepointorupdateAllKeyspaceGcBarriers.coordinator.coordinator.CreateChangefeedandRemoveChangefeednow callupdateGCSafepointByChangefeed.coordinator/changefeed/backoff.go,coordinator/orchestrator/reactor_state.go, and other coordinator components have been updated to refer tokeyspaceinstead ofnamespace.Etcd Key Management Refactoring:
etcd.NamespacedPrefixhas been renamed toetcd.KeyspacePrefix.etcd.DefaultClusterAndNamespacePrefixhas been renamed toetcd.DefaultClusterAndKeyspacePrefix.TaskPositionKeyPrefix,ChangefeedStatusKeyPrefix,GetEtcdKeyChangeFeedList,GetEtcdKeyChangeFeedInfo,GetEtcdKeyJob) have been updated to use the newKeyspaceterminology.etcd.CDCKeynow includes aKeyspacefield.Downstream Adapter and Sink Components:
TableTriggerEventDispatcherGauge,EventDispatcherGauge,CreateDispatcherDuration,CheckpointTsMessageDuration,WorkerBatchDuration,ConflictDetectDuration,RedoFlushLogDurationHistogram,CloudStorageWriteBytesGauge,ClaimCheckSendMessageDuration, etc.) acrossdownstreamadapter/dispatchermanager,downstreamadapter/sink/cloudstorage,downstreamadapter/sink/kafka,downstreamadapter/sink/mysql/causality,downstreamadapter/sink/mysql,downstreamadapter/sink/pulsar,downstreamadapter/sink/redo,pkg/sink/codec/avro,pkg/sink/codec/common,pkg/sink/codec/encoder_group,pkg/sink/kafka/claimcheck,pkg/sink/kafka/metrics_collector,pkg/sink/pulsarhave been updated fromnamespacetokeyspace.cloudstorage/sink.go,kafka/sink.go,pulsar/dml_producer.go,redo/meta.go) now usekeyspace.pkg/redo/writer/file/file.goandpkg/redo/writer/memory/file_worker.gohas been updated to usecommon.DefaultKeyspace.downstreamadapter/sink/eventrouter/topic/expression.gohas been updated.pkg/sink/kafka/options.go) and MySQL TLS configuration names (pkg/sink/mysql/config.go) now includekeyspace.Migration Logic Updates (
pkg/migrate/migrate.go):ChangefeedID.DisplayName.Keyspacetocommon.DefaultKeyspacefor existing changefeeds.New Feature: Keyspace Validation Middleware (
api/middleware/middleware.go):KeyspaceCheckerMiddlewarewhich validates thekeyspacequery parameter in incoming API requests. This middleware usespkg/pdutil.PDAPIClient.LoadKeyspaceto check if the specified keyspace exists and is in anENABLEDstate in PD.pkg/pdutil.PDAPIClientinterface and its implementation have been extended with aLoadKeyspacemethod to facilitate this validation.KeyspaceCheckerMiddleware.Other Minor Changes:
JobTableIDandJobHistoryIDimports fromgithub1.rensumo.top/pingcap/tidb/pkg/ddltogithub1.rensumo.top/pingcap/tidb/pkg/meta/metadefinlogservice/schemastore/ddl_job_fetcher.go.session.SetSchemaLeasetovardef.SetSchemaLeaseinpkg/common/event/util.go.topologyTiDBandtopologyTiDBTTLimports fromgithub1.rensumo.top/pingcap/tidb/pkg/domain/infosynctogithub1.rensumo.top/pingcap/tidb/pkg/domain/serverinfoinpkg/upstream/topo.go.minGCBarrierGaugeandcdcGCBarrierGaugewith anamespacelabel (which should be interpreted askeyspace) inpkg/txnutil/gc/metrics.go.TryUpdateKeypsaceGCBarriermethod and related structures topkg/txnutil/gc/gc_manager.go.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
namespace) has been effectively replaced bykeyspace. Clients interacting with the TiCDC API (v2) that previously used thenamespaceparameter will need to update their requests to usekeyspaceinstead.pkg/migrate) is in place to handle existing data in etcd, seamlessly transitioning from the old "namespace" structure to the new "keyspace" structure. This ensures that existing changefeeds continue to function after an upgrade.heartbeatpb.ChangefeedIDmessage has been updated to include a newkeyspacefield, while the oldnamespacefield is marked as deprecated. This approach maintains backward compatibility for existing protobuf consumers while enabling the transition to the new terminology.Do you need to update user documentation, design documentation or monitoring documentation?
v2/changefeedsendpoints) must be updated to reflect thekeyspaceparameter. Any user guides or CLI examples referencingnamespacewill need to be updated tokeyspace.metrics.FinishedOperatorCount.WithLabelValues(common.DefaultKeyspace, ...)).Release note