metrics: fix more metrics

[3AceShowHand]

What problem does this PR solve?

Issue Number: close #xxx

What is changed and how it works?

• record the max core of the instance

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hicqu for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gemini-code-assist]

Summary of Changes

Hello @3AceShowHand, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the TiCDC server's observability by ensuring that Go runtime metrics are properly recorded upon server initialization. This change improves the completeness of collected metrics, aiding in better performance monitoring and debugging.

Highlights

• Metrics Enhancement: Integrated the pkg/metrics module and added a call to metrics.RecordGoRuntimeSettings() during server startup to ensure Go runtime metrics are captured.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[ti-chi-bot]

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

_{📖 For more info, you can check the "Contribute Code" section in the development guide.}

[gemini-code-assist]

Code Review

This pull request adds a call to record Go runtime metrics. My review identifies that the metrics are being recorded but are not registered, which means they won't be exposed. I've provided a suggestion to call metrics.InitMetrics to properly initialize all server metrics for the new architecture. This will ensure all relevant metrics are correctly exposed.

[gemini-code-assist]

While adding RecordGoRuntimeSettings is correct for capturing Go runtime metrics, the associated Prometheus metrics need to be registered to be exposed. It appears that metrics.InitMetrics is not called for the new server architecture, which would lead to these and other metrics not being available.

You should initialize the metrics before recording them. Please also remember to add the necessary import for prometheus: "github.com/prometheus/client_golang/prometheus".

Suggested change

	metrics.RecordGoRuntimeSettings()
	metrics.InitMetrics(prometheus.DefaultRegisterer)
	metrics.RecordGoRuntimeSettings()