[DNM] #1943
[DNM] #1943
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @lidezhu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request, marked as "Do Not Merge" (DNM), introduces logging improvements for cloud storage schema handling and adjusts integration test configurations. The changes appear to be part of a debugging or focused testing effort, specifically narrowing down the scope of CI storage tests to a single partition table scenario.
Highlights
- Enhanced Logging: Added detailed log.Info statements within pkg/sink/cloudstorage/path.go to provide better visibility into schema file existence checks and when existing schema files with matching checksums are identified.
- Test Configuration Adjustment: Modified tests/integration_tests/canal_json_storage_partition_table/conf/diff_config.toml to swap the roles of tidb0 and mysql1 as source and target instances, and updated their respective data source configurations.
- CI Test Scope Narrowing: Updated tests/integration_tests/run_heavy_it_in_ci.sh to make all storage_groups run only the canal_json_storage_partition_table integration test, likely for focused testing or debugging.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
ti-chi-bot
bot
added
the
size/M
There was a problem hiding this comment.
Code Review
This pull request introduces extensive logging in the cloud storage schema handling logic and modifies test configurations. While the added logging is useful for debugging, the implementation in pkg/sink/cloudstorage/path.go has significant code duplication that should be refactored. More critically, the changes in tests/integration_tests/run_heavy_it_in_ci.sh disable most of the storage integration tests, which is a major issue that must be addressed before merging. The changes in diff_config.toml appear to be related to this test setup.
| storage_groups=( | ||
| # G00 | ||
| 'generate_column many_pk_or_uk multi_source' | ||
| 'canal_json_storage_partition_table' | ||
| # G01 | ||
| csv_storage_update_pk_clustered csv_storage_update_pk_nonclustered | ||
| '' | ||
| 'canal_json_storage_partition_table' | ||
| # G02 | ||
| 'canal_json_storage_basic canal_json_storage_partition_table' | ||
| 'canal_json_storage_partition_table' | ||
| # G03 | ||
| 'csv_storage_basic storage_csv_update' | ||
| 'canal_json_storage_partition_table' | ||
| # G04 | ||
| 'ddl_for_split_tables_with_random_move_table' | ||
| 'canal_json_storage_partition_table' | ||
| # G05 | ||
| 'move_table drop_many_tables' | ||
| 'canal_json_storage_partition_table' | ||
| # G06 | ||
| 'cdc default_value' | ||
| 'canal_json_storage_partition_table' | ||
| # G07 | ||
| 'merge_table resolve_lock force_replicate_table' | ||
| 'canal_json_storage_partition_table' | ||
| # G08 | ||
| 'tidb_mysql_test' | ||
| 'canal_json_storage_partition_table' | ||
| # G09 | ||
| 'ddl_for_split_tables_with_merge_and_split' | ||
| 'canal_json_storage_partition_table' | ||
| # G10 | ||
| 'ddl_for_split_tables_with_random_merge_and_split' | ||
| 'canal_json_storage_partition_table' | ||
| # G11 | ||
| # fail_over_ddl_mix_with_syncpoint | ||
| '' | ||
| 'canal_json_storage_partition_table' | ||
| # G12 | ||
| 'ddl_with_random_move_table' | ||
| 'canal_json_storage_partition_table' | ||
| # G13 | ||
| 'fail_over region_merge' | ||
| 'canal_json_storage_partition_table' | ||
| # G14 | ||
| 'fail_over_ddl_mix' | ||
| 'canal_json_storage_partition_table' | ||
| # G15 | ||
| '' | ||
| 'canal_json_storage_partition_table' | ||
| ) |
There was a problem hiding this comment.
This change replaces all test suites in storage_groups with a single test, canal_json_storage_partition_table. While this might be useful for debugging, it would prevent all other storage integration tests from running in CI. This change must be reverted before the pull request is merged.
ti-chi-bot
bot
added
size/L
|
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Contribute Code" section in the development guide. |
|
@lidezhu: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #xxx
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note