Skip to content

Conversation

asddongmen
Copy link
Collaborator

@asddongmen asddongmen commented Jan 20, 2025

Signed-off-by: dongmen [email protected]

What problem does this PR solve?

Issue Number: ref #442

What is changed and how it works?

  1. This pull request makes the server exit directly when it encounters the CDC:ErrCaptureSuicide error, which indicates a fatal error has occurred. We believe that rather than resetting all components internally and restarting the server in a loop (which involves resetting some states and is quite complex), it is more appropriate to simply exit and let external operational tools like the operator or TiUP restart the CDC process.

  2. It also improves the server closing process by ensuring all components are closed before the server exits. To achieve this, it copies some packages from the tiflow repository into this repository and makes some modifications.

  3. Fix the integration test case capture_session_done_during_task, which is a byproduct of the improvements in step 1.

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Copy link

ti-chi-bot bot commented Jan 20, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 20, 2025
@asddongmen asddongmen self-assigned this Jan 20, 2025
@asddongmen asddongmen marked this pull request as ready for review January 21, 2025 02:39
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2025
@asddongmen asddongmen changed the title *: fix some server restart related its *: Improve cdc server exit logic Jan 21, 2025
Copy link

ti-chi-bot bot commented Jan 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Jan 21, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-21 02:45:52.861904814 +0000 UTC m=+148880.192824218: ☑️ agreed by hongyunyan.

@ti-chi-bot ti-chi-bot bot merged commit 5d823d2 into pingcap:master Jan 21, 2025
22 of 25 checks passed
@asddongmen asddongmen deleted the more_changes branch January 22, 2025 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants