Skip to content

Conversation

asddongmen
Copy link
Collaborator

@asddongmen asddongmen commented Jan 24, 2025

Signed-off-by: dongmen [email protected]

What problem does this PR solve?

Issue Number: ref #442

What is changed and how it works?

This pull request fix the following integration test cases:

  1. changefeed_resume_with_checkpoint_ts
  2. capture_suicide_while_balance_table
  3. kv_client_stream_reconnect

And remove a useless test case:

  1. owner_remove_table_error

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Copy link

ti-chi-bot bot commented Jan 24, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 24, 2025
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 24, 2025
@asddongmen asddongmen marked this pull request as ready for review January 24, 2025 06:46
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 24, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 24, 2025
Copy link

ti-chi-bot bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 24, 2025
Copy link

ti-chi-bot bot commented Jan 24, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-24 07:55:03.688911106 +0000 UTC m=+426631.019830511: ☑️ agreed by hongyunyan.

@asddongmen
Copy link
Collaborator Author

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2025
@asddongmen
Copy link
Collaborator Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2025
Signed-off-by: dongmen <[email protected]>
@ti-chi-bot ti-chi-bot bot merged commit d9aed28 into pingcap:master Jan 24, 2025
10 of 12 checks passed
@asddongmen asddongmen deleted the fix_more_its_0124 branch March 31, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants