-
Notifications
You must be signed in to change notification settings - Fork 521
fix(pd): fix the pd name of tc with across k8s opt #4721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #4721 +/- ##
==========================================
+ Coverage 61.56% 71.32% +9.76%
==========================================
Files 206 210 +4
Lines 22750 25494 +2744
==========================================
+ Hits 14006 18184 +4178
+ Misses 7444 5985 -1459
- Partials 1300 1325 +25
|
/test pull-e2e-kind-across-kubernetes |
/test pull-e2e-kind |
1 similar comment
/test pull-e2e-kind |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 46a0800
|
/test pull-e2e-kind-basic |
/test pull-e2e-kind-br |
/test pull-e2e-kind-serial pull-e2e-kind-tikv-scale-simultaneously |
/test e2e-examples |
/test pull-e2e-kind-across-kubernetes |
/test pull-e2e-kind-serial |
/test pull-e2e-kind-across-kubernetes |
1 similar comment
/test pull-e2e-kind-across-kubernetes |
/test pull-e2e-kind-across-kubernetes |
1 similar comment
/test pull-e2e-kind-across-kubernetes |
/test pull-e2e-kind-across-kubernetes |
/test pull-e2e-kind-across-kubernetes |
Signed-off-by: ti-srebot <[email protected]>
cherry pick to release-1.3 in PR #4728 |
What problem does this PR solve?
Now if
spec.acrossK8s
is set butspec.clusterDomain
is empty in TC, the upgrading process of PD will be blocked because the name of pd in status is mismatched with the return result of functionPdName
.For now, if
spec.clusterDomain
is empty, thePdName
will return pod name whetherspec.acrossK8s
is true or false. However, ifspec.acrossK8s
is true, the real pd name generated by start-script is the full domain name.After this PR merged,
PdName
will also return full domain name whenspec.acrossK8s
is trueWhat is changed and how does it work?
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.