Skip to content

Conversation

liubog2008
Copy link
Member

@liubog2008 liubog2008 commented Sep 23, 2022

What problem does this PR solve?

Now if spec.acrossK8s is set but spec.clusterDomain is empty in TC, the upgrading process of PD will be blocked because the name of pd in status is mismatched with the return result of function PdName.

For now, if spec.clusterDomain is empty, the PdName will return pod name whether spec.acrossK8s is true or false. However, if spec.acrossK8s is true, the real pd name generated by start-script is the full domain name.

After this PR merged, PdName will also return full domain name when spec.acrossK8s is true

What is changed and how does it work?

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 23, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • KanShiori
  • csuzhangxc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2022

Codecov Report

Merging #4721 (0a4c29a) into master (35f941e) will increase coverage by 9.76%.
The diff coverage is 80.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4721      +/-   ##
==========================================
+ Coverage   61.56%   71.32%   +9.76%     
==========================================
  Files         206      210       +4     
  Lines       22750    25494    +2744     
==========================================
+ Hits        14006    18184    +4178     
+ Misses       7444     5985    -1459     
- Partials     1300     1325      +25     
Flag Coverage Δ
e2e 57.64% <80.00%> (?)
unittest 61.55% <66.66%> (-0.01%) ⬇️

@liubog2008
Copy link
Member Author

/test pull-e2e-kind-across-kubernetes

@liubog2008
Copy link
Member Author

/test pull-e2e-kind

1 similar comment
@KanShiori
Copy link
Collaborator

/test pull-e2e-kind

@KanShiori
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 46a0800

@liubog2008
Copy link
Member Author

/test pull-e2e-kind-basic

@liubog2008
Copy link
Member Author

/test pull-e2e-kind-br

@KanShiori
Copy link
Collaborator

/test pull-e2e-kind-serial pull-e2e-kind-tikv-scale-simultaneously

@liubog2008
Copy link
Member Author

/test e2e-examples

@liubog2008
Copy link
Member Author

/test pull-e2e-kind-across-kubernetes

@liubog2008
Copy link
Member Author

/test pull-e2e-kind-serial

@KanShiori
Copy link
Collaborator

/test pull-e2e-kind-across-kubernetes

1 similar comment
@KanShiori
Copy link
Collaborator

/test pull-e2e-kind-across-kubernetes

@KanShiori
Copy link
Collaborator

/test pull-e2e-kind-across-kubernetes

1 similar comment
@KanShiori
Copy link
Collaborator

/test pull-e2e-kind-across-kubernetes

@liubog2008
Copy link
Member Author

/test pull-e2e-kind-across-kubernetes

@liubog2008
Copy link
Member Author

/test pull-e2e-kind-across-kubernetes

@KanShiori KanShiori merged commit fe6bef8 into pingcap:master Sep 29, 2022
ti-srebot pushed a commit to ti-srebot/tidb-operator that referenced this pull request Sep 29, 2022
@ti-srebot
Copy link
Contributor

cherry pick to release-1.3 in PR #4728

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants