test: stabilize TestAnalyzeColumnsWithVirtualColumnIndex (#56798)

close #56797

Author: tangenta

pkg/resourcegroup/runaway/manager.go

@@ -155,8 +155,8 @@ func (rm *Manager) RunawayRecordFlushLoop() {
 	quarantineRecordCh := rm.quarantineRecordChan()
 	staleQuarantineRecordCh := rm.staleQuarantineRecordChan()
 	flushThreshold := flushThreshold()
-	// recordMap is used to deduplicate records.
-	recordMap = make(map[recordKey]*Record, flushThreshold)
+	// recordMap is used to deduplicate records which will be inserted into `mysql.tidb_runaway_queries`.
+	recordMap := make(map[recordKey]*Record, flushThreshold)
 
 	flushRunawayRecords := func() {
 		if len(recordMap) == 0 {

pkg/resourcegroup/runaway/record.go

@@ -68,9 +68,6 @@ type Record struct {
 	Repeats int
 }
 
-// recordMap is used to save records which will be inserted into `mysql.tidb_runaway_queries` by function `flushRunawayRecords`.
-var recordMap map[recordKey]*Record
-
 // recordKey represents the composite key for record key in `tidb_runaway_queries`.
 type recordKey struct {
 	ResourceGroupName string

pkg/resourcegroup/runaway/record_test.go

@@ -45,7 +45,7 @@ func TestRecordKey(t *testing.T) {
 	assert.NotEqual(t, hash1, hash3, "Hashes should not be equal for different keys")
 
 	// Test MapKey method
-	recordMap = make(map[recordKey]*Record)
+	recordMap := make(map[recordKey]*Record)
 	record1 := &Record{
 		ResourceGroupName: "group1",
 		SQLDigest:         "digest1",